fix(slack): respect top-level requireMention config #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `channels.slack.requireMention` setting was defined in the schema but never passed to `resolveSlackChannelConfig()`, which always defaulted to `true`. This meant setting `requireMention: false` at the top level had no effect—channels still required mentions. Pass `slackCfg.requireMention` as `defaultRequireMention` to the resolver and use it as the fallback instead of hardcoded `true`. Co-Authored-By: Claude Opus 4.5 <[email protected]>
a8f6f5a to
151a551
Compare
steipete
added a commit
to mneves75/clawdbot
that referenced
this pull request
Jan 15, 2026
steipete
added a commit
to mneves75/clawdbot
that referenced
this pull request
Jan 15, 2026
cpojer
pushed a commit
to cpojer/clawdbot
that referenced
this pull request
Jan 16, 2026
cpojer
pushed a commit
to cpojer/clawdbot
that referenced
this pull request
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
channels.slack.requireMentionsetting was defined in the schema but never passed toresolveSlackChannelConfig(), which always defaulted totruerequireMention: falseat the top level had no effect—channels still required mentionsslackCfg.requireMentionasdefaultRequireMentionto the resolver and use it as the fallbackTest plan
pnpm vitest run src/slack/monitor)channels.slack.requireMention: falseand verify bot responds without @mention🤖 Generated with Claude Code