fix: unify daemon service label resolution with env parameter #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Wow. Benjamin . This... is the FIRST PR where codex didn't find anything to criticise. Kudos. |
ae01d35 to
2b113c4
Compare
Contributor
|
Landed via temp rebase onto main. Thanks @bjesuiter! |
Contributor
Author
|
Thank you for the kudos, really appreciate that! Went over it a few times with opus and codex and fixed things, so yeah, it's nice that the engineering effort still shows and is appreciated, even in the age of ai 🥰 Also, thank you for merging so quickly, now I can sleep better, knowing that my blunder bug with the first pr is gone 😂✨ |
cpojer
pushed a commit
to cpojer/clawdbot
that referenced
this pull request
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this
FIX: Bug where clawdbot doctor did not get passed the CLAWDBOT_PROFILE env correctly
due to my earlier "profile" param refactoring here: #671
merged in this commit: 77cf40d
DOCS: Improve docs around multi-gateway usage and setup
Summary
{ env }parameter instead of separate{ profile }parametersenv.CLAWDBOT_PROFILEinternally, ensuring consistent label resolution across launchd, systemd, and schtasksChanges
isLoaded,stop,restartmethods now take{ env }instead of{ profile }Testing