Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[full-ci] Enhance getSpaceByName: check local cache before Graph API calls#1574

Merged
v-scharf merged 2 commits into
mainfrom
get-space-from-cache-or-graph
Sep 30, 2025
Merged

[full-ci] Enhance getSpaceByName: check local cache before Graph API calls#1574
v-scharf merged 2 commits into
mainfrom
get-space-from-cache-or-graph

Conversation

@v-scharf

@v-scharf v-scharf commented Sep 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Added getCreatedSpace() method to fetch spaces from locally saved cache
  • Updated getSpaceByName() to:
    • Check local cache first
    • Fetch personal space via Graph API if not in cache
    • Fall back to listing all available spaces via Graph API for users/admins
  • Reduced unnecessary API calls and improved performance
  • Added inline comments explaining the logic

@v-scharf v-scharf force-pushed the get-space-from-cache-or-graph branch from 95316e6 to 570b23d Compare September 29, 2025 14:21
@v-scharf v-scharf marked this pull request as ready for review September 29, 2025 16:06
@v-scharf v-scharf force-pushed the get-space-from-cache-or-graph branch from 570b23d to c299c14 Compare September 29, 2025 16:06
@v-scharf v-scharf requested review from butonic and rhafer September 29, 2025 16:06
@v-scharf v-scharf force-pushed the get-space-from-cache-or-graph branch from c299c14 to 00baf45 Compare September 29, 2025 18:35
rhafer
rhafer requested changes Sep 30, 2025
View reviewed changes

@rhafer rhafer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a minor error in one of the comments.
Also (optionally) there might be "easier" endpoints for getting the personal space of a specific user.

Comment thread tests/acceptance/bootstrap/SpacesContext.php Outdated
Comment thread tests/acceptance/bootstrap/SpacesContext.php
@v-scharf v-scharf requested a review from rhafer September 30, 2025 10:30
@v-scharf v-scharf merged commit 2524678 into main Sep 30, 2025
99 checks passed
@v-scharf v-scharf deleted the get-space-from-cache-or-graph branch September 30, 2025 11:08
@openclouders openclouders mentioned this pull request Sep 30, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhafer rhafer rhafer approved these changes
@butonic butonic Awaiting requested review from butonic

Assignees

No one assigned

Labels

Type:Test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-scharf @rhafer