Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: support svg as icon#538

Merged
kulmann merged 1 commit into
mainfrom
change-favicon-to-svg
Mar 31, 2025
Merged

feat: support svg as icon#538
kulmann merged 1 commit into
mainfrom
change-favicon-to-svg

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Mar 31, 2025

Copy link
Copy Markdown
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

Comment thread services/idp/Makefile
.PHONY: assets/identifier/static/favicon.svg # force overwrite
assets/identifier/static/favicon.svg:
cp src/images/favicon.svg assets/identifier/static/favicon.svg
rm assets/identifier/static/favicon.ico

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove original lico ico

@AlexAndBear AlexAndBear requested a review from kulmann March 31, 2025 10:07
@AlexAndBear AlexAndBear marked this pull request as ready for review March 31, 2025 10:09
@kulmann kulmann merged commit ff91a50 into main Mar 31, 2025
@kulmann kulmann deleted the change-favicon-to-svg branch March 31, 2025 11:03
@openclouders openclouders mentioned this pull request Mar 31, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

favicon does not work with Firefox

2 participants