Fix broken links in opencloud_full README.md#643
Conversation
|
Thanks for the approval! It looks like the CI is failing due to the following issue: The error What Needs to Happen:This issue must be addressed in the upstream repository since the workflow and its permissions are controlled there. Here are some potential solutions for the upstream maintainers:
|
|
@michaelstingl I implemented 3), can you rebase? |
95f6eb6 to
c2410b2
Compare
|
Hi @micbar, I've rebased the branch, but the workflow is still failing with After further research, the issue appears to be more fundamental: GitHub Actions never passes repository secrets to pull requests from forks for security reasons - even when PATs are stored as secrets. The recommended solution would be to modify the label check job to only run on internal PRs: jobs:
label:
# Only run if PR is not from a fork
if: github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
permissions:
issues: write
pull-requests: write
steps:
- uses: mheap/github-action-required-labels@v5
with:
mode: minimum
count: 1
labels: |
Type:Bug
Type:Enhancement
# ... more labels ...
add_comment: true
token: ${{ secrets.GH_TOKEN_OPENCLOUDERS }}Alternatively, you could manually add the label so the PR can proceed. Thanks! |
|
@michaelstingl Can you add the permissions check in your pr and remove the token setting? that would be awesome. |
|
@micbar I've updated the PR to include the suggested changes:
This should fix the workflow issue. Thanks for your help! |
Description
Update the links in the opencloud_full deployment example README to point to the correct documentation URLs.
Related Issue
Motivation and Context
The links in the README were outdated and returning 404 errors. This PR updates the links to point to the current documentation structure.
How Has This Been Tested?
Types of changes
Checklist: