Before caring about the tests, I'd love to know if this is matching the code standards 😼

Before caring about the tests, I'd love to know if this is matching the code standards 😼

I like the approach! Building two groups (normal and special) and then sorting those groups according to the weight prop sounds reasonable and gives us the expected result. 👍

Sorry, but I am not really convinced that this approach is good. What exactly makes a role "special"? And even if we think they're somehow special, I don't think we should hardcode that somewhere deep in the code.

Roles already have weights for ordering them. We just set the weight to 0 everywhere and then try some clever sorting based on the number of permissions they grant. Maybe that is the wrong approach. Why not just initialize the weights correctly from the beginning and just sort by weights?

Same question here. Why do we override the backend weight? If something is wrong, we should change the weight in the backend.

@tbsbdr can the gatekeeper give us their opinion

I'd rather show Can view (secure) under Can view and Cannot access at last.

I'd prefer the order like you propsed it.

@rhafer @dragotin what do you think, can be backport this to stable-2.0? The original behaviour was quite annoying, but it's not more than that... don't know how strict you are with backports.