Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add profile photo#864

Merged
fschade merged 12 commits into
opencloud-eu:mainfrom
dragonchaser:add-profile-photo
May 26, 2025
Merged

Add profile photo#864
fschade merged 12 commits into
opencloud-eu:mainfrom
dragonchaser:add-profile-photo

Conversation

@fschade

@fschade fschade commented May 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Implements the functionality described in opencloud-eu/opencloud#732, which focuses on the ability to add custom profile pictures.

** MS-Graph API **

Related Issue

Motivation and Context

allow users to upload and manage their profile pictures

How Has This Been Tested?

  • unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Todo:

@fschade fschade force-pushed the add-profile-photo branch from 458a632 to 7ea7887 Compare May 20, 2025 13:09
dragonchaser and others added 8 commits May 20, 2025 15:10
@fschade fschade force-pushed the add-profile-photo branch 2 times, most recently from 5fa9000 to 478fd1a Compare May 20, 2025 13:35
@fschade fschade force-pushed the add-profile-photo branch from 478fd1a to 2504006 Compare May 20, 2025 14:09
@fschade fschade marked this pull request as ready for review May 20, 2025 14:09
@fschade

fschade commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

@AlexAndBear please check if ok for you

@AlexAndBear AlexAndBear mentioned this pull request May 21, 2025
Merged
7 tasks
@AlexAndBear

AlexAndBear commented May 22, 2025

Copy link
Copy Markdown
Member

@AlexAndBear please check if ok for you

Ok for me

kulmann
kulmann reviewed May 22, 2025
View reviewed changes

@kulmann kulmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the endpoint named $value? That's awful to debug.

Screenshot 2025-05-22 at 15 49 39

@fschade

fschade commented May 22, 2025

Copy link
Copy Markdown
Member Author

Why is the endpoint named $value? That's awful to debug.

Screenshot 2025-05-22 at 15 49 39

I asked myself the same thing, MS probably thinks it's a nice idea... without words...

GET /me/photo/$value
GET /users/{id | userPrincipalName}/photo/$value
GET /groups/{id}/photo/$value
GET /me/contacts/{id}/photo/$value
GET /users/{id | userPrincipalName}/contacts/{id}/photo/$value
GET /me/contactfolders/{contactFolderId}/contacts/{id}/photo/$value
GET /users/{id | userPrincipalName}/contactfolders/{contactFolderId}/contacts/{id}/photo/$value
GET /team/{id}/photo/$value

because the "top"-level enpoints reserved for the meta data...

GET /me/photo
GET /me/photos
GET /users/{id | userPrincipalName}/photo
GET /groups/{id}/photo
GET /me/contacts/{id}/photo
GET /users/{id | userPrincipalName}/contacts/{id}/photo
GET /me/contactfolders/{contactFolderId}/contacts/{id}/photo
GET /users/{id | userPrincipalName}/contactfolders/{contactFolderId}/contacts/{id}/photo
GET /team/{id}/photo

https://learn.microsoft.com/en-us/graph/api/profilephoto-get?view=graph-rest-1.0&tabs=http

@dragonchaser dragonchaser requested review from butonic and kulmann May 23, 2025 08:10
@v-scharf v-scharf mentioned this pull request May 23, 2025
Merged
@fschade

fschade commented May 26, 2025

Copy link
Copy Markdown
Member Author

the relevant changes are located in:

everything else ist more or less just noise to make the pr testable

@fschade fschade merged commit db7d053 into opencloud-eu:main May 26, 2025
@openclouders openclouders mentioned this pull request May 26, 2025
Merged
1 task
@dragonchaser dragonchaser deleted the add-profile-photo branch May 26, 2025 09:57
@fschade fschade mentioned this pull request May 27, 2025
Merged
9 tasks
@v-scharf v-scharf mentioned this pull request May 28, 2025
Open
@fschade fschade mentioned this pull request May 30, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhafer rhafer rhafer approved these changes
@kulmann kulmann Awaiting requested review from kulmann
@butonic butonic Awaiting requested review from butonic

Assignees

@rhafer rhafer

@dragonchaser dragonchaser

@fschade fschade

Labels

Type:Enhancement Type:Feature-Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Server] persist user profile pictures

5 participants

@fschade @AlexAndBear @rhafer @kulmann @dragonchaser