Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[full-ci] Change eicar_com.zip virus file and update tests#992

Merged
fschade merged 1 commit into
mainfrom
zip-report
Jun 4, 2025
Merged

[full-ci] Change eicar_com.zip virus file and update tests#992
fschade merged 1 commit into
mainfrom
zip-report

Conversation

@prashant-gurung899

@prashant-gurung899 prashant-gurung899 commented Jun 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR does the following:

  • add new eicar_com.zip file as the previous one was of 0 byte.
  • rearrange tests related to eicar_com.zip.
  • remove eicar_com.zip related scenarios that were listed in the expected-to-fail file.

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

@prashant-gurung899 prashant-gurung899 mentioned this pull request Jun 4, 2025
Closed
@prashant-gurung899 prashant-gurung899 changed the title [full-ci][tests-only] Change zip file with virus [full-ci] Change zip file with virus Jun 4, 2025
@prashant-gurung899 prashant-gurung899 self-assigned this Jun 4, 2025
@prashant-gurung899 prashant-gurung899 changed the title [full-ci] Change zip file with virus [full-ci] Change eicar_com.zip virus file and update tests Jun 4, 2025
@prashant-gurung899 prashant-gurung899 force-pushed the zip-report branch 3 times, most recently from 5c51750 to f2e956c Compare June 4, 2025 07:12
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review June 4, 2025 08:58
individual-it
individual-it approved these changes Jun 4, 2025
View reviewed changes

@individual-it individual-it left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHAT? The issue was only that the file did not had any content? 🙈

@fschade fschade merged commit 14a623e into main Jun 4, 2025
72 checks passed
@fschade fschade deleted the zip-report branch June 4, 2025 10:41
@openclouders openclouders mentioned this pull request Jun 4, 2025
Merged
1 task
@prashant-gurung899

prashant-gurung899 commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

WHAT? The issue was only that the file did not had any content? 🙈

My bad 😮‍💨

@fschade

fschade commented Jun 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

WHAT? The issue was only that the file did not had any content? 🙈

My bad 😮‍💨

shit happens, you fixed it with the speed of light, THX for that ❤️

@prashant-gurung899

prashant-gurung899 commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author

shit happens, you fixed it with the speed of light, THX for that ❤️

No worries 😃 Thank you as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@individual-it individual-it individual-it approved these changes
@fschade fschade fschade approved these changes
@anon-pradip anon-pradip Awaiting requested review from anon-pradip
@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha
@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@prashant-gurung899 prashant-gurung899

Labels

Type:Test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prashant-gurung899 @fschade @individual-it