Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: sorting of spaces is faulty when space names contain numbers#2429

Merged
AlexAndBear merged 9 commits into
mainfrom
issues/2422
Apr 23, 2026
Merged

fix: sorting of spaces is faulty when space names contain numbers#2429
AlexAndBear merged 9 commits into
mainfrom
issues/2422

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Comment thread packages/web-app-admin-settings/src/components/Spaces/SpacesList.vue Outdated
@AlexAndBear AlexAndBear marked this pull request as ready for review April 22, 2026 18:25
@AlexAndBear AlexAndBear changed the title fix: sorting of spaces is faulty when spaces only have numbers fix: sorting of spaces is faulty when space names contain numbers Apr 22, 2026

@kulmann kulmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I sort by some criterion OTHER than the space name, the sorting falls back to the pure lexicographical sorting. See screenshot.

Image

Edit: thanks for the hint: Together with the backend changes in opencloud-eu/opencloud#2657 the behaviour is correct. 🥳

@kulmann kulmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs linting fixes, but otherwise works great 🥳

@AlexAndBear AlexAndBear merged commit 60c05fb into main Apr 23, 2026
29 checks passed
@AlexAndBear AlexAndBear deleted the issues/2422 branch April 23, 2026 08:24
@openclouders openclouders mentioned this pull request Apr 23, 2026
1 task
@github-project-automation github-project-automation Bot moved this from Qualification to Done in OpenCloud Team Board Apr 23, 2026
@github-project-automation github-project-automation Bot moved this to Qualification in OpenCloud Team Board Apr 23, 2026
@AlexAndBear AlexAndBear self-assigned this Apr 23, 2026
@openclouders openclouders mentioned this pull request May 11, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Numeric ordering is wrong

2 participants