Fix mail validation layout issue#2492
Merged
Merged
Conversation
f7ea6b3 to
921e314
Compare
AlexAndBear
requested changes
May 11, 2026
| isContactEmailInvalid(modelValue.email) ? $gettext('Please enter a valid email') : '' | ||
| " | ||
| :fix-message-line="true" | ||
| :fix-message-line="false" |
Member
There was a problem hiding this comment.
you can just remove this line, as it defaults to false
Member
|
Please also give this PR a meaningful title, as it lands in the release notes |
AlexAndBear
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix removes an unnecessary extra line in the mail validation, which caused the design to break.