Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: expiration date does not get applied when creating a new share#2514

Merged
AlexAndBear merged 1 commit into
mainfrom
issues/2235
May 18, 2026
Merged

fix: expiration date does not get applied when creating a new share#2514
AlexAndBear merged 1 commit into
mainfrom
issues/2235

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented May 17, 2026

Copy link
Copy Markdown
Member

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

JammingBen
JammingBen reviewed May 18, 2026
View reviewed changes

@JammingBen JammingBen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one edge case: when adding an expiration date when inviting a new space member, the date gets set correctly, but it's missing in the members list. You then need to reload the page for the expiration date icon and the context menu actions to display correctly.

@AlexAndBear

AlexAndBear commented May 18, 2026

Copy link
Copy Markdown
Member Author

Found one edge case: when adding an expiration date when inviting a new space member, the date gets set correctly, but it's missing in the members list. You then need to reload the page for the expiration date icon and the context menu actions to display correctly.

Good catch, let's fix that in a follow up

@AlexAndBear AlexAndBear merged commit b021323 into main May 18, 2026
29 checks passed
@AlexAndBear AlexAndBear deleted the issues/2235 branch May 18, 2026 12:21
@openclouders openclouders mentioned this pull request May 18, 2026
Merged
1 task
@AlexAndBear

AlexAndBear commented May 18, 2026

Copy link
Copy Markdown
Member Author

Found one edge case: when adding an expiration date when inviting a new space member, the date gets set correctly, but it's missing in the members list. You then need to reload the page for the expiration date icon and the context menu actions to display correctly.

This has been fixed with the latest backend update

@v-scharf v-scharf mentioned this pull request May 19, 2026
Merged
3 tasks
@JammingBen JammingBen mentioned this pull request Jun 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JammingBen JammingBen JammingBen approved these changes
@tammi-23 tammi-23 Awaiting requested review from tammi-23

Assignees

No one assigned

Labels

Type:Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sharing: expiration date does not get applied

2 participants

@AlexAndBear @JammingBen