gNMI-1.10 Added PTX10002-36QDD for skipping Fabric check#5649
gNMI-1.10 Added PTX10002-36QDD for skipping Fabric check#5649priyaranjannanda wants to merge 3 commits into
Conversation
priyaranjannanda
commented
Jul 1, 2026
- Added PTX10002-36QDD for skipping Fabric check
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the telemetry basic check test to include the PTX10002-36QDD hardware platform in the exclusion list for fabric checks. This ensures that the test correctly handles hardware platform compatibility for this specific device model. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5649 / 69d7e0bVirtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request adds the 'PTX10002-36QDD' hardware model to the skip list in 'TestComponentParent' due to compatibility issues. The feedback advises adding a 'TODO' comment with a link to an issue tracker to document this temporary model-specific check, as required by the repository's style guide.
| t.Run(tc.desc, func(t *testing.T) { | ||
|
|
||
| if len(compList[tc.desc]) == 0 && (dut.Model() == "DCS-7280CR3K-32D4" || dut.Model() == "CISCO-8202-32FH-M") { | ||
| if len(compList[tc.desc]) == 0 && (dut.Model() == "DCS-7280CR3K-32D4" || dut.Model() == "CISCO-8202-32FH-M" || dut.Model() == "PTX10002-36QDD") { |
There was a problem hiding this comment.
Hardcoding model-specific checks directly in the test file is discouraged. According to the repository's general rules, temporary vendor-specific or model-specific checks are acceptable in test files only if they are accompanied by a TODO comment and a link to an issue tracker, while waiting for a formal deviation to be introduced. Please add a TODO comment with a tracking issue URL.
// TODO: PTX10002-36QDD does not support certain components. Move this to a deviation once confirmed.
// https://github.com/openconfig/featureprofiles/issues/XXXXX
if len(compList[tc.desc]) == 0 && (dut.Model() == "DCS-7280CR3K-32D4" || dut.Model() == "CISCO-8202-32FH-M" || dut.Model() == "PTX10002-36QDD") {References
- Use deviations to allow alternate OC paths or CLI commands to achieve the same operational intent. Do not use them to skip validation or change the intent of the test. (link)
- Temporary vendor-specific checks (e.g., checking dut.Vendor()) are acceptable in test files if they are accompanied by a TODO comment and a link to an issue tracker, while waiting for the vendor to confirm the behavior and formally introduce a deviation.
navaneethyv
left a comment
There was a problem hiding this comment.
please take care of the comment