Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Certz-1.1 and Certz-1.2#5653

Open
sudhirakondi wants to merge 11 commits into
openconfig:mainfrom
priyacj:certz1.1
Open

Certz-1.1 and Certz-1.2#5653
sudhirakondi wants to merge 11 commits into
openconfig:mainfrom
priyacj:certz1.1

Conversation

@sudhirakondi

@sudhirakondi sudhirakondi commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Pushing test code for Certz1.1 and 1.2.
This code was previous merged via PR # 3684, however reverted by PR 5114 due to some issues. Raising a new pull request now with changes.

@sudhirakondi sudhirakondi requested a review from a team as a code owner July 2, 2026 04:52
@OpenConfigBot

OpenConfigBot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Pull Request Functional Test Report for #5653 / f4c10a4

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 Certz-1: gNSI Client Certificate Tests
Cisco 8000E status
 Certz-1: gNSI Client Certificate Tests
Cisco XRd status
 Certz-1: gNSI Client Certificate Tests
Juniper ncPTX status
 Certz-1: gNSI Client Certificate Tests
Nokia SR Linux status
 Certz-1: gNSI Client Certificate Tests
Openconfig Lemming status
 Certz-1: gNSI Client Certificate Tests

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 Certz-1: gNSI Client Certificate Tests
Cisco 8808 status
 Certz-1: gNSI Client Certificate Tests
Juniper PTX10008 status
 Certz-1: gNSI Client Certificate Tests
Nokia 7250 IXR-10e status
 Certz-1: gNSI Client Certificate Tests

Help

@gemini-code-assist

gemini-code-assist Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive test coverage for Certz 1.1 and 1.2 functionality. It includes a new test suite that validates client certificate loading and authentication across various CA configurations, alongside minor infrastructure improvements to the test setup utilities to ensure more robust script execution and error reporting.

Highlights

  • Test Implementation: Added a new client certificate test suite for Certz 1.1 and 1.2, covering various CA configurations and key types.
  • Script Execution Fix: Updated the test data script execution to use /bin/sh -c, ensuring better compatibility and command handling.
  • Error Handling Improvements: Updated several validation functions to use t.Fatalf instead of t.Errorf to halt execution immediately upon critical test failures.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 2, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new client certificates test (client_certificates_test.go) for GNSI certz rotation, updates the CA generation script to support custom directories, and improves error handling in setup_service.go by using t.Fatalf instead of t.Errorf for capability check failures. The review feedback focuses on Go best practices, recommending the removal of package-level global variables in favor of local declarations within the test function, and simplifying flag usage by dereferencing them directly instead of using redundant helper functions.

Comment thread feature/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated
Comment thread feature/gnsi/certz/tests/client_certificates/client_certificates_test.go
Comment thread feature/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@priyacj priyacj priyacj left review comments
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

juniper-pr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sudhirakondi @OpenConfigBot @priyacj