Extended coverage for Interface hold-time test#5662
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the test coverage for interface hold-time configurations. It updates existing documentation and test procedures to reflect new design specifications for hold-time up durations and introduces a new test case to validate traffic loss behavior during link failures. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5662 / 330a65cVirtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request updates the interface hold-time test documentation to increase the hold-time up configuration from 5 seconds to 180 seconds (3 minutes) and adjusts the test procedure steps accordingly. It also introduces a new test case (TC6) to measure and verify traffic loss duration, and adds a canonical OpenConfig JSON snippet. The reviewer feedback suggests using standard GitHub Flavored Markdown inline math delimiters ($) instead of LaTeX-style delimiters to ensure correct rendering of math expressions.
| * Verify that the traffic loss duration \(t_{\text{loss}}\) satisfies the relation: | ||
| * \(t_{\text{loss}} \le \text{hold-time down} + \text{failover tolerance}\) | ||
| * Specifically, \(t_{\text{loss}} \le 300\text{ ms} + 100\text{ ms} = 400\text{ ms}\). |
There was a problem hiding this comment.
GitHub Flavored Markdown (GFM) uses $ for inline math expressions instead of LaTeX-style \( and \) delimiters. Using \( and \) will prevent the math from rendering correctly on GitHub.
| * Verify that the traffic loss duration \(t_{\text{loss}}\) satisfies the relation: | |
| * \(t_{\text{loss}} \le \text{hold-time down} + \text{failover tolerance}\) | |
| * Specifically, \(t_{\text{loss}} \le 300\text{ ms} + 100\text{ ms} = 400\text{ ms}\). | |
| * Verify that the traffic loss duration $t_{\text{loss}}$ satisfies the relation: | |
| * $t_{\text{loss}} \le \text{hold-time down} + \text{failover tolerance}$ | |
| * Specifically, $t_{\text{loss}} \le 300\text{ ms} + 100\text{ ms} = 400\text{ ms}$. |
Enhancing the coverage for Interface hold-time test
-Updated the summaries and procedures to test the current design specifications: hold-time down of 300 ms and hold-time up of 180,000 ms (3 minutes).
-Modified TC4 - long up to wait for 185 seconds and assert state recovery matching the 180s timer.
-Added a new testcase TC6 - traffic loss duration to inject continuous data-plane traffic and assert that the total packet loss duration