Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gRIBI scale: juniper no mix of (un)tagged interfaces#5670

Merged
rohit-rp merged 1 commit into
mainfrom
gribi_scale_juniper_tagged_interfaces
Jul 10, 2026
Merged

gRIBI scale: juniper no mix of (un)tagged interfaces#5670
rohit-rp merged 1 commit into
mainfrom
gribi_scale_juniper_tagged_interfaces

Conversation

@dracazacula

Copy link
Copy Markdown
Contributor

No description provided.

@dracazacula dracazacula requested a review from a team as a code owner July 6, 2026 16:25
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the metadata configuration for several gRIBI OTG tests to account for platform-specific constraints on Juniper hardware. By explicitly defining a deviation regarding tagged and untagged subinterface mixing, the tests will now correctly handle Juniper's interface requirements during full-scale testing scenarios.

Highlights

  • Platform Exception Addition: Added a new platform exception for Juniper devices to the metadata configuration files.
  • Deviation Configuration: Enabled the 'no_mix_of_tagged_and_untagged_subinterfaces' deviation for Juniper platforms across multiple gRIBI test suites.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dracazacula dracazacula requested a review from gggsmith July 6, 2026 16:25
@dracazacula dracazacula changed the title juniper no mix of (un)tagged interfaces gRIBI scale: juniper no mix of (un)tagged interfaces Jul 6, 2026
@OpenConfigBot

Copy link
Copy Markdown

Pull Request Functional Test Report for #5670 / 73cc303

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
status
status
status
TE-14.5: gRIBI Scaling - full scale setup, target T0
TE-14.3: gRIBI Scaling - full scale setup, target T1
TE-14.4: gRIBI Scaling - full scale setup, target T2
TE-14.6: gRIBI Scaling - all scenarios but with minimal scaling parameters
3af6d0f0 Log
Cisco 8000E status
status
status
status
TE-14.5: gRIBI Scaling - full scale setup, target T0
TE-14.3: gRIBI Scaling - full scale setup, target T1
TE-14.4: gRIBI Scaling - full scale setup, target T2
TE-14.6: gRIBI Scaling - all scenarios but with minimal scaling parameters
09fdf9e2 Log
Cisco XRd status
status
status
status
TE-14.5: gRIBI Scaling - full scale setup, target T0
TE-14.3: gRIBI Scaling - full scale setup, target T1
TE-14.4: gRIBI Scaling - full scale setup, target T2
TE-14.6: gRIBI Scaling - all scenarios but with minimal scaling parameters
4cf00b5e Log
Juniper ncPTX status
status
status
status
TE-14.5: gRIBI Scaling - full scale setup, target T0
TE-14.3: gRIBI Scaling - full scale setup, target T1
TE-14.4: gRIBI Scaling - full scale setup, target T2
TE-14.6: gRIBI Scaling - all scenarios but with minimal scaling parameters
509dd83e Log
Nokia SR Linux status
status
status
status
TE-14.5: gRIBI Scaling - full scale setup, target T0
TE-14.3: gRIBI Scaling - full scale setup, target T1
TE-14.4: gRIBI Scaling - full scale setup, target T2
TE-14.6: gRIBI Scaling - all scenarios but with minimal scaling parameters
5d1cfa33 Log
Openconfig Lemming status
status
status
status
TE-14.5: gRIBI Scaling - full scale setup, target T0
TE-14.3: gRIBI Scaling - full scale setup, target T1
TE-14.4: gRIBI Scaling - full scale setup, target T2
TE-14.6: gRIBI Scaling - all scenarios but with minimal scaling parameters
c682783e Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
status
status
status
TE-14.5: gRIBI Scaling - full scale setup, target T0
TE-14.3: gRIBI Scaling - full scale setup, target T1
TE-14.4: gRIBI Scaling - full scale setup, target T2
TE-14.6: gRIBI Scaling - all scenarios but with minimal scaling parameters
Cisco 8808 status
status
status
status
TE-14.5: gRIBI Scaling - full scale setup, target T0
TE-14.3: gRIBI Scaling - full scale setup, target T1
TE-14.4: gRIBI Scaling - full scale setup, target T2
TE-14.6: gRIBI Scaling - all scenarios but with minimal scaling parameters
Juniper PTX10008 status
status
status
status
TE-14.5: gRIBI Scaling - full scale setup, target T0
TE-14.3: gRIBI Scaling - full scale setup, target T1
TE-14.4: gRIBI Scaling - full scale setup, target T2
TE-14.6: gRIBI Scaling - all scenarios but with minimal scaling parameters
Nokia 7250 IXR-10e status
status
status
status
TE-14.5: gRIBI Scaling - full scale setup, target T0
TE-14.3: gRIBI Scaling - full scale setup, target T1
TE-14.4: gRIBI Scaling - full scale setup, target T2
TE-14.6: gRIBI Scaling - all scenarios but with minimal scaling parameters

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the metadata.textproto files for several gRIBI full-scale tests (gribi_full_scale_down, gribi_full_scale_t0, gribi_full_scale_t1, and gribi_full_scale_t2) to add platform exceptions for Juniper devices, specifically enabling the 'no_mix_of_tagged_and_untagged_subinterfaces' deviation. There are no review comments, and I have no feedback to provide.

@dracazacula dracazacula requested a review from rohit-rp July 6, 2026 16:32
@rohit-rp rohit-rp merged commit 6d3473d into main Jul 10, 2026
22 of 23 checks passed
@rohit-rp rohit-rp deleted the gribi_scale_juniper_tagged_interfaces branch July 10, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants