gNMI-1.18: Fix Arista IC pattern to exclude FAP core sub-components#5673
gNMI-1.18: Fix Arista IC pattern to exclude FAP core sub-components#5673mrigank-arista wants to merge 1 commit into
Conversation
The Arista icPattern regex ^SwitchChip matches both parent FAP components (SwitchChip3/0) and core sub-components (SwitchChip3/0.0). Core sub-components do not support backplane-facing-capacity telemetry because fabric bandwidth is a per-FAP property, not per-core. Tighten the regex to ^SwitchChip\d+/\d+$ to match only parent FAPs. Also remove duplicate OpenConfig Path and RPC Coverage section from README.md.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Arista component matching logic to improve the accuracy of backplane-facing-capacity telemetry tests. By restricting the regex pattern, the test now correctly ignores core sub-components that do not support the required telemetry. Additionally, the documentation has been cleaned up to remove duplicate information. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the 'OpenConfig Path and RPC Coverage' section from the README.md of the sampled backplane capacity counters test. Additionally, it updates the regular expression pattern used for Arista devices in the test code to specifically match ^SwitchChip\d+/\d+$ instead of ^SwitchChip. I have no feedback to provide.
The Arista icPattern regex ^SwitchChip matches both parent FAP components (SwitchChip3/0) and core sub-components (SwitchChip3/0.0). Core sub-components do not support backplane-facing-capacity telemetry because fabric bandwidth is a per-FAP property, not per-core. Tighten the regex to ^SwitchChip\d+/\d+$ to match only parent FAPs.
Also remove duplicate OpenConfig Path and RPC Coverage section from README.md.