Code commit for TE-8.1: DUT Daemon Failure#584
Merged
Conversation
Pull Request Test Coverage Report for Build 3238389388
💛 - Coveralls |
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
Author
|
/gcbrun |
liulk
reviewed
Oct 6, 2022
liulk
reviewed
Oct 6, 2022
Member
|
/gcbrun |
Ankur19
requested changes
Oct 8, 2022
…s, changed gNOI kill signal from sigkill to sigterm and changed traffic flow setup as suggested.
Ankur19
reviewed
Oct 12, 2022
Contributor
|
Adding go-reviewer here. Functionality looks good. |
…d startTraffic/stopAndVerifyTraffic instead
Contributor
Author
|
Hi @liulk , could you also please help resolve the below failure: Thanks! |
Ankur19
approved these changes
Oct 12, 2022
Ankur19
previously approved these changes
Oct 12, 2022
Contributor
You need to rebase your branch to openconfig/main. |
liulk
suggested changes
Oct 12, 2022
Contributor
|
/gcbrun |
… to check for DUT vendor at the start of the test with the help of a map and moved PID finding logic into its own function
liulk
approved these changes
Oct 12, 2022
Contributor
|
/gcbrun |
Contributor
|
CloudBuild failure is due to a different reason, so merge for now. |
singh-prem
pushed a commit
to mingyangcisco/featureprofiles
that referenced
this pull request
Dec 13, 2022
* Code commit for TE-8.1: DUT Daemon Failure * Updated file permissions and made some minor changes in the code comments * Updated file permissions again * Removed newline in the end * Addressed review comments: updated Arista and Cisco gRIBI daemon names, changed gNOI kill signal from sigkill to sigterm and changed traffic flow setup as suggested. * Addressed review comments openconfig#2: removed testTraffic and reused startTraffic/stopAndVerifyTraffic instead * Addressed review comments openconfig#3: Gribi -> GRIBI, added support to check for DUT vendor at the start of the test with the help of a map and moved PID finding logic into its own function
prinikasn
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Code commit for TE-8.1: DUT Daemon Failure * Updated file permissions and made some minor changes in the code comments * Updated file permissions again * Removed newline in the end * Addressed review comments: updated Arista and Cisco gRIBI daemon names, changed gNOI kill signal from sigkill to sigterm and changed traffic flow setup as suggested. * Addressed review comments #2: removed testTraffic and reused startTraffic/stopAndVerifyTraffic instead * Addressed review comments #3: Gribi -> GRIBI, added support to check for DUT vendor at the start of the test with the help of a map and moved PID finding logic into its own function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included in this commit:
Resolves #162