cmake: avoid amending of CMAKE_COMPILER_IS_[GNUCXX|CLANGCXX|CCACHE] vars #11167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Recommended compiler checks: - GCC: CV_GCC - Clang: CV_CLANG - fixed problem with CMAKE_CXX_COMPILER_ID=Clang/AppleClang mess on MacOSX Details: cmake --help-policy CMP0025 - do not declare Clang as GCC compiler
Contributor
|
looks good! 👍 |
opencv-pushbot
pushed a commit
that referenced
this pull request
Mar 28, 2018
seiko2plus
added a commit
to seiko2plus/opencv
that referenced
this pull request
Apr 11, 2018
* remove unnecessary defines from vsx_utils * fix v_load_expand, load lower 64bit * use vec_ld, vec_st with alignment load/store on all types except 64bit * map v_extract to v_rotate_right * update license header * enable VSX by default on clang since opencv#11167
FantasqueX
added a commit
to FantasqueX/opencv
that referenced
this pull request
Dec 26, 2023
Two CMake variable are marked as deprecated and "#TODO next release: remove this". It is introduced in opencv#11167 which is before the release of 4.0. Since it's deprecated almost six years ago, I think it's OK to remove them.
6 tasks
FantasqueX
added a commit
to FantasqueX/opencv
that referenced
this pull request
Dec 27, 2023
CMake variable `CMAKE_COMPILER_IS_CCACHE` is marked as deprecated and "# FIXIT Avoid setting of CMAKE_ variables". It is introduced in opencv#11167 which is before the release of 4.0. Since it's deprecated almost six years ago, I think it's OK to remove them. Related: opencv#24771
6 tasks
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
Two CMake variable are marked as deprecated and "#TODO next release: remove this". It is introduced in opencv#11167 which is before the release of 4.0. Since it's deprecated almost six years ago, I think it's OK to remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- GCC:
CV_GCC- Clang:
CV_CLANGCMAKE_CXX_COMPILER_ID=Clang/AppleClangmess on MacOSX (STREQUAL->MATCHES)Details:
cmake --help-policy CMP0025related #8923 (part 2)