Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vpisarev
Copy link
Contributor

this should speedup distance transform 5x5

@ghost ghost assigned apavlenko Jul 22, 2013
@vpisarev
Copy link
Contributor Author

Andrey, please, review

@apavlenko
Copy link
Contributor

:shipit:

opencv-pushbot pushed a commit that referenced this pull request Jul 22, 2013
@opencv-pushbot opencv-pushbot merged commit 8b6afd6 into opencv:2.4 Jul 22, 2013
@SpecLad SpecLad mentioned this pull request Jul 22, 2013
@Earthwings
Copy link

This breaks the build here (Linux, tried IPP 7.1 and 8.0).

[ 7%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/distransform.cpp.o
src/modules/imgproc/src/distransform.cpp: In function ‘void cv::distanceTransform(cv::InputArray, cv::OutputArray, cv::OutputArray, int, int, int)’:
src/modules/imgproc/src/distransform.cpp:750:37: error: base operand of ‘->’ has non-pointer type ‘cv::Mat’
src/modules/imgproc/src/distransform.cpp:750:48: error: base operand of ‘->’ has non-pointer type ‘cv::Mat’
src/modules/imgproc/src/distransform.cpp:752:28: error: base operand of ‘->’ has non-pointer type ‘cv::Mat’
src/modules/imgproc/src/distransform.cpp:752:43: error: base operand of ‘->’ has non-pointer type ‘cv::Mat’
src/modules/imgproc/src/distransform.cpp:753:28: error: base operand of ‘->’ has non-pointer type ‘cv::Mat’
src/modules/imgproc/src/distransform.cpp:753:42: error: base operand of ‘->’ has non-pointer type ‘cv::Mat’
make[2]: *** [modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/distransform.cpp.o] Error 1
make[1]: *** [modules/imgproc/CMakeFiles/opencv_imgproc.dir/all] Error 2
make: *** [all] Error 2

asclepix pushed a commit to asclepix/opencv_2.4.x that referenced this pull request Mar 25, 2023
…pencv#1165). Note: this may break binary compatibility, but since the class is not wrapped in Java and not exposed in Windows API, for example (it's considered internal-use class for flann), the effect should be minimal
asmorkalov pushed a commit that referenced this pull request Apr 3, 2024
[BugFix] dnn (ONNX): Foce dropping constant inputs in parseClip if they are shared #25319

Resolves #25278
Merge with opencv/opencv_extra#1165

In Gold-YOLO ,`Div` has a constant input `B=6` which is then parsed into a `Const` layer in the ONNX importer, but `Clip` also has the shared constant input `max=6` which is already a `Const` layer and then connected to `Elementwise` layer. This should not happen because in the `forward()` of `Elementwise` layer, the legacy code goes through and apply activation to each input. More details on #25278 (comment).

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
klatism pushed a commit to klatism/opencv that referenced this pull request May 17, 2024
[BugFix] dnn (ONNX): Foce dropping constant inputs in parseClip if they are shared opencv#25319

Resolves opencv#25278
Merge with opencv/opencv_extra#1165

In Gold-YOLO ,`Div` has a constant input `B=6` which is then parsed into a `Const` layer in the ONNX importer, but `Clip` also has the shared constant input `max=6` which is already a `Const` layer and then connected to `Elementwise` layer. This should not happen because in the `forward()` of `Elementwise` layer, the legacy code goes through and apply activation to each input. More details on opencv#25278 (comment).

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants