Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Tengine lite update #18323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 23, 2020
Merged

Tengine lite update #18323

merged 11 commits into from
Sep 23, 2020

Conversation

@liqi-c
Copy link
Contributor

@liqi-c liqi-c commented Sep 13, 2020 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

alalek
alalek reviewed Sep 13, 2020
View reviewed changes
3rdparty/libtengine/tengine.cmake Outdated
SET (TENGINE_TOOLCHIN_FLAG "-march=armv7-a")
elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL aarch64) ## AARCH64
SET(CONFIG_ARCH_ARM64 ON)
SET (TENGINE_TOOLCHIN_FLAG "-march=armv8-a")
Copy link
Member

@alalek alalek Sep 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOOLCHIN

typo

Copy link
Contributor Author

@liqi-c liqi-c Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

modules/dnn/src/dnn.cpp Outdated
LayerData &ld = it->second;
Ptr<Layer> layerCur = ld.layerInstance;

if (!strcmp(ld.type.c_str(),"Convolution"))
Copy link
Member

@alalek alalek Sep 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Layer::finalize() doesn't work here?
(or just the first run of Layer::forward(), check integration of convolutionOp from OpenCL backend)

Copy link
Contributor Author

@liqi-c liqi-c Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to Layer::forward . please checkout again

alalek
alalek reviewed Sep 17, 2020
View reviewed changes
3rdparty/libtengine/tengine.cmake Outdated
SET (TENGINE_TOOLCHAIN_FLAG "-march=armv7-a")
elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL aarch64) ## AARCH64
SET(CONFIG_ARCH_ARM64 ON)
SET (TENGINE_TOOLCHAIN_FLAG "-march=armv8-a")
Copy link
Member

@alalek alalek Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space before bracket.

modules/dnn/CMakeLists.txt Outdated
if(EXISTS ${TENGINE_LIBRARIES})
list(APPEND libs ${TENGINE_LIBRARIES})
if(EXISTS ${TENGINE_LIBRARIES})
list(APPEND libs -Wl,--whole-archive ${TENGINE_LIBRARIES} -Wl,--no-whole-archive)
Copy link
Member

@alalek alalek Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(EXISTS ${TENGINE_LIBRARIES})

Don't work with list as variable value.
Broken indentation.

No difference between both code paths. ocv_add_dependencies() is misused (required opencv modules) and does nothing.

Copy link
Contributor Author

@liqi-c liqi-c Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

alalek
alalek reviewed Sep 21, 2020
View reviewed changes
3rdparty/libtengine/tengine.cmake Outdated
SET(OCV_TENGINE_URL "https://github.com/OAID/Tengine/archive/") #url2
SET(tengine_md5sum f51ca8f3963faeeff3f019a6f6edc206) #md5sum2
#SET(OCV_TENGINE_URL "https://github.com/OAID/Tengine/archive/") #url2
SET(OCV_TENGINE_URL "https://github.com/liqi-c/Tengine/archive/") #url2. Tmp url
Copy link
Member

@alalek alalek Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need that for testing. Upstream URL should work fine with commits from fork.

Copy link
Contributor Author

@liqi-c liqi-c Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@alalek alalek merged commit 3fc1487 into opencv:master Sep 23, 2020
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@liqi-c
Merge pull request opencv#18323 from liqi-c:tengine-lite-update
ca20c21 
Tengine lite update

* update tengine

* Modify for arm32 build.

* format optimization

* add teng_ befor some tengine api

* update graph_t to teng_graph_t

* update graph_t to teng_graph_t

* Code structure optimization

* optimization

* optimization

* remove space

* update tengine url

Co-authored-by: liqi <[email protected]>
@fengyuentau fengyuentau mentioned this pull request Aug 8, 2023
Merged
6 tasks
asmorkalov pushed a commit that referenced this pull request Aug 9, 2023
@fengyuentau
Merge pull request #24122 from fengyuentau:remove_tengine
ba70ec9 
dnn: cleanup of tengine backend #24122

🚀 Cleanup for OpenCV 5.0. Tengine backend is added for convolution layer speedup on ARM CPUs, but it is not maintained and the convolution layer on our default backend has reached similar performance to that of Tengine.

Tengine backend related PRs:
- #16724
- #18323

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
@fengyuentau @thewoz
Merge pull request opencv#24122 from fengyuentau:remove_tengine
5bc1b0d 
dnn: cleanup of tengine backend opencv#24122

🚀 Cleanup for OpenCV 5.0. Tengine backend is added for convolution layer speedup on ARM CPUs, but it is not maintained and the convolution layer on our default backend has reached similar performance to that of Tengine.

Tengine backend related PRs:
- opencv#16724
- opencv#18323

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
@fengyuentau @thewoz
Merge pull request opencv#24122 from fengyuentau:remove_tengine
58c9d67 
dnn: cleanup of tengine backend opencv#24122

🚀 Cleanup for OpenCV 5.0. Tengine backend is added for convolution layer speedup on ARM CPUs, but it is not maintained and the convolution layer on our default backend has reached similar performance to that of Tengine.

Tengine backend related PRs:
- opencv#16724
- opencv#18323

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: dnn platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@liqi-c @alalek