G-API: New python operations API #19982

TolyaTalamanov · 2021-04-26T13:56:51Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.3.0:20.04
build_image:Custom Win=openvino-2021.3.0
build_image:Custom Mac=openvino-2021.3.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

modules/gapi/misc/python/package/gapi/init.py

modules/python/src2/cv2.cpp

modules/gapi/misc/python/test/test_gapi_sample_pipelines.py

TolyaTalamanov · 2021-04-26T14:01:47Z

@dkurt @alalek Have a look, please

…-python-operation-api

TolyaTalamanov · 2021-04-26T15:17:24Z

modules/gapi/misc/python/pyopencv_gapi.hpp

@@ -496,6 +509,14 @@ static cv::GRunArgs run_py_kernel(PyObject* kernel,
        }

        PyObject* result = PyObject_CallObject(kernel, args);
+        if (PyErr_Occurred()) {
+            PyErr_PrintEx(0);


Always print traceback even if exception is handled in python code. Can be changed later, because retrieving traceback from python exception in c++ is not-trivial

mshabunin · 2021-04-27T13:47:52Z

Looks like this patch is not compatible with Python limited API build option: -DPYTHON3_LIMITED_API=ON

../opencv/modules/python/src2/cv2.cpp: In function 'PyObject* PyInit_cv2()':
../opencv/modules/python/src2/cv2.cpp:2388:9: error: 'PyRun_SimpleFile' was not declared in this scope
 2388 |         PyRun_SimpleFile(file, filename);
      |         ^~~~~~~~~~~~~~~~

Perhaps lower level Py_CompileString + PyEval_EvalCode must be used instead of PyRun_* functions.

See also:

TolyaTalamanov · 2021-04-27T17:03:55Z

Looks like this patch is not compatible with Python limited API build option: -DPYTHON3_LIMITED_API=ON
../opencv/modules/python/src2/cv2.cpp: In function 'PyObject* PyInit_cv2()':
../opencv/modules/python/src2/cv2.cpp:2388:9: error: 'PyRun_SimpleFile' was not declared in this scope
 2388 |         PyRun_SimpleFile(file, filename);
      |         ^~~~~~~~~~~~~~~~
Perhaps lower level Py_CompileString + PyEval_EvalCode must be used instead of PyRun_* functions.

See also:

Added cmake switch to enable limited python API (stage 3) #14736

https://www.python.org/dev/peps/pep-0384/

https://github.com/python/cpython/blob/5b1e50256b6532667b6d31debc350f6c7d3f30aa/Include/pythonrun.h#L148-L167

I believe this line should removed at all during integration @alalek

alalek

Straightforward import of provided code as cv2.gapi doesn't work because this submodule is already defined by binaries extension.
Investigating other paths (for Python 3.x+ only).

Updates will be added later.

alalek · 2021-04-27T18:24:56Z

modules/gapi/misc/python/test/test_gapi_sample_pipelines.py

+        class GAddImpl:
+            @staticmethod
+            def run(img0, img1):
+                raise 'Error'


This is not correct:

raise 'Error' TypeError: exceptions must derive from BaseException

What do you mean ? Just derive it from BaseException ?

This is a Python error message.
Use proper classes for raising exceptions in Python, e.g. Exception

alalek · 2021-04-27T18:28:33Z

modules/gapi/misc/python/test/test_gapi_sample_pipelines.py

@@ -522,5 +375,288 @@ def test_custom_op_goodFeaturesToTrack(self):
                                      np.array(actual, dtype=np.float32).flatten(), cv.NORM_INF))


+    def test_invalid_op(self):


With fixed absolute path I'm observing sporadic crashed on this test case or tests cleanup.
Stacktrace is not really useful (python-only runtime code).

Ran 17 tests in 0.064s OK Segmentation fault (core dumped)

test_invalid_op (test_gapi_sample_pipelines.gapi_sample_pipelines) ... Segmentation fault (core dumped)

Launch command example:

OPENCV_PYTEST_FILTER=test_gapi_sample* ./setup_vars.sh python3 ../opencv/modules/python/test/test.py -v --repo ../opencv

Please confirm.

Works fine for me:

atalaman@nnlicv179:~/workspace/opencv-python/build$ OPENCV_PYTEST_FILTER=test_gapi_sample* ./setup_vars.sh python3 ../../opencv-python/modules/python/test/test.py -v --repo ../../opencv-python Setting vars for OpenCV 4.5.2-dev Append PYTHONPATH: /home/atalaman/workspace/opencv-python/build/python_loader Testing OpenCV 4.5.2-dev Local repo path: ../../opencv-python Tests filter: test_gapi_sample*.py Discovering python tests from: /home/atalaman/workspace/opencv-python/build found 0 tests Discovering python tests from: /home/atalaman/workspace/opencv-python/modules/python/test found 0 tests Discovering python tests from: /home/atalaman/workspace/opencv-python/modules/ml/misc/python/test found 0 tests Discovering python tests from: /home/atalaman/workspace/opencv-python/modules/dnn/misc/python/test found 0 tests Discovering python tests from: /home/atalaman/workspace/opencv-python/modules/features2d/misc/python/test found 0 tests Discovering python tests from: /home/atalaman/workspace/opencv-python/modules/videoio/misc/python/test found 0 tests Discovering python tests from: /home/atalaman/workspace/opencv-python/modules/calib3d/misc/python/test found 0 tests Discovering python tests from: /home/atalaman/workspace/opencv-python/modules/objdetect/misc/python/test found 0 tests Discovering python tests from: /home/atalaman/workspace/opencv-python/modules/stitching/misc/python/test found 0 tests Discovering python tests from: /home/atalaman/workspace/opencv-python/modules/video/misc/python/test found 0 tests Discovering python tests from: /home/atalaman/workspace/opencv-python/modules/gapi/misc/python/test found 17 tests test_array_with_custom_type (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_custom_op_add (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_custom_op_addC (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_custom_op_boundingRect (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_custom_op_goodFeaturesToTrack (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_custom_op_mean (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_custom_op_size (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_custom_op_sizeR (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_custom_op_split3 (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_invalid_op (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_invalid_op_input (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_invalid_outMeta (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_opaq_with_custom_type (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_pipeline_with_custom_kernels (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_raise_in_kernel (test_gapi_sample_pipelines.gapi_sample_pipelines) ... /usr/lib/python3/dist-packages/apport/report.py:13: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses import fnmatch, glob, traceback, errno, sys, atexit, locale, imp, stat Traceback (most recent call last): File "/home/atalaman/workspace/opencv-python/modules/gapi/misc/python/test/test_gapi_sample_pipelines.py", line 540, in run raise Exception('Error') Exception: Error ok test_raise_in_outMeta (test_gapi_sample_pipelines.gapi_sample_pipelines) ... Traceback (most recent call last): File "/home/atalaman/workspace/opencv-python/modules/gapi/misc/python/test/test_gapi_sample_pipelines.py", line 562, in outMeta raise 'Error' TypeError: exceptions must derive from BaseException ok test_stateful_kernel (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok ---------------------------------------------------------------------- Ran 17 tests in 0.044s OK

Stack trace dump of crashes from gdb and Python 3.9:

... Discovering python tests from: /home/alalek/projects/opencv/dev/modules/gapi/misc/python/test found 17 tests test_array_with_custom_type (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_custom_op_add (test_gapi_sample_pipelines.gapi_sample_pipelines) ... [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer ok test_custom_op_addC (test_gapi_sample_pipelines.gapi_sample_pipelines) ... [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer ok test_custom_op_boundingRect (test_gapi_sample_pipelines.gapi_sample_pipelines) ... [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer ok test_custom_op_goodFeaturesToTrack (test_gapi_sample_pipelines.gapi_sample_pipelines) ... [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer ok test_custom_op_mean (test_gapi_sample_pipelines.gapi_sample_pipelines) ... [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Expected cv::GProtoInputArgs for argument 'ins' [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Expected cv::GMat for argument 'out' ok test_custom_op_size (test_gapi_sample_pipelines.gapi_sample_pipelines) ... [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer ok test_custom_op_sizeR (test_gapi_sample_pipelines.gapi_sample_pipelines) ... [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer ok test_custom_op_split3 (test_gapi_sample_pipelines.gapi_sample_pipelines) ... [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer ok test_invalid_op (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_invalid_op_input (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_invalid_outMeta (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_opaq_with_custom_type (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok test_pipeline_with_custom_kernels (test_gapi_sample_pipelines.gapi_sample_pipelines) ... [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer [ WARN:0] global /home/alalek/projects/opencv/dev/modules/python/src2/cv2.cpp (110) emit_failmsg Bindings conversion failed: Argument 'normType' is required to be an integer ok test_raise_in_kernel (test_gapi_sample_pipelines.gapi_sample_pipelines) ... Traceback (most recent call last): File "/home/alalek/projects/opencv/dev/modules/gapi/misc/python/test/test_gapi_sample_pipelines.py", line 540, in run raise Exception('Error') Exception: Error ok test_raise_in_outMeta (test_gapi_sample_pipelines.gapi_sample_pipelines) ... Traceback (most recent call last): File "/home/alalek/projects/opencv/dev/modules/gapi/misc/python/test/test_gapi_sample_pipelines.py", line 562, in outMeta raise NotImplementedError("outMeta ins't implemented") NotImplementedError: outMeta ins't implemented ok test_stateful_kernel (test_gapi_sample_pipelines.gapi_sample_pipelines) ... ok ---------------------------------------------------------------------- Ran 17 tests in 0.023s OK Thread 1 "python3" received signal SIGSEGV, Segmentation fault. 0x00007fffe9898ba0 in PyFloatArrType_Type () from /home/alalek/penv3/lib64/python3.9/site-packages/numpy/core/_multiarray_umath.cpython-39-x86_64-linux-gnu.so (gdb) bt #0 0x00007fffe9898ba0 in PyFloatArrType_Type () at /home/alalek/penv3/lib64/python3.9/site-packages/numpy/core/_multiarray_umath.cpython-39-x86_64-linux-gnu.so #1 0x00007ffff7d3ffdf in tupletraverse () at /lib64/libpython3.9.so.1.0 #2 0x00007ffff7d3fc65 in deduce_unreachable () at /lib64/libpython3.9.so.1.0 #3 0x00007ffff7d3f97d in collect () at /lib64/libpython3.9.so.1.0 #4 0x00007ffff7dc2a0e in collect_with_callback () at /lib64/libpython3.9.so.1.0 #5 0x00007ffff7df3a0e in PyGC_Collect () at /lib64/libpython3.9.so.1.0 #6 0x00007ffff7df3427 in Py_FinalizeEx () at /lib64/libpython3.9.so.1.0 #7 0x00007ffff7df379c in Py_Exit () at /lib64/libpython3.9.so.1.0 #8 0x00007ffff7df0f3b in handle_system_exit () at /lib64/libpython3.9.so.1.0 #9 0x00007ffff7df0c6d in PyErr_PrintEx () at /lib64/libpython3.9.so.1.0 #10 0x00007ffff7de962e in PyRun_SimpleFileExFlags () at /lib64/libpython3.9.so.1.0 #11 0x00007ffff7de6aa6 in Py_RunMain () at /lib64/libpython3.9.so.1.0 #12 0x00007ffff7db8f8d in Py_BytesMain () at /lib64/libpython3.9.so.1.0 #13 0x00007ffff7a9b1e2 in __libc_start_main () at /lib64/libc.so.6 #14 0x000055555555509e in _start () (gdb)

@alalek Could you try it once again ?

modules/gapi/misc/python/package/gapi/init.py

…-python-operation-api

modules/gapi/misc/python/package/gapi/__init__.py

dkurt

👍

modules/gapi/misc/python/package/gapi/__init__.py

modules/gapi/misc/python/test/test_gapi_sample_pipelines.py

modules/python/package/cv2/_extra_py_code/__init__.py

modules/gapi/misc/python/package/gapi/__init__.py

TolyaTalamanov · 2021-04-30T09:40:06Z

@dmatveev Have a look, please

TolyaTalamanov · 2021-04-30T09:40:30Z

@alalek Have a look, once again, please, looks like all work.

l-bat

LGTM 👍

dmatveev

Not a python expert, but have some general concerns. Experts please correct me. Like the solution overall

dmatveev · 2021-04-30T18:27:04Z

modules/gapi/misc/python/package/gapi/__init__.py

+
+    class Any():
+        def __new__(self):
+            return cv.GArray(cv.gapi.CV_ANY)


So I believe the idea of this file was to define everything in Python but... can it be auto-generated from our C++ definitions? At least these parts with types and enums..

You're right the idea is correct, but there are some difficulties, let me explain:

cv.GArray.Any and others should be really types.
I mean, user use it as types in kernel definitions:

@cv.gapi.op('custom.op', in_types=[cv.GOpaque.Any, cv.GOpaque.String], out_types=[cv.GOpaque.Any]) ....

It would be clear to create object the same way

g_any = cv.GOpaque.Any() // instead of cv.GOpaqueT(cv.gapi.CV_ANY)

You can't achieve that by using enums in c++, right ?

The second problem is that in c++ it should be looks like:

class GArrayT { ... GAPI_EXPORTS_W_SIMPLE Any { ... }; };

Unfortunately generator doesn't support such syntax

My point is that if there is no difference where it will be defined it is better to go the simplest way and do it in python

dmatveev · 2021-04-30T18:28:43Z

modules/gapi/misc/python/test/test_gapi_sample_pipelines.py

+             ('ocl'    , cv.gapi.core.ocl.kernels()),
+             ('cpu'    , cv.gapi.core.cpu.kernels()),
+             ('fluid'  , cv.gapi.core.fluid.kernels())
+             # ('plaidml', cv.gapi.core.plaidml.kernels())


BTW it'd be a nice-to-have feature - test particular G-API capabilities which are available in this particular build, and cal functions like this plaidml.kernels() conditionally, if the capability exist (like, you know, #ifdef in runtime)

Ok, I'll file a ticket

dmatveev · 2021-04-30T18:30:17Z

modules/python/common.cmake

+        list(SORT extra_py_files)
+        foreach(f ${extra_py_files})
+          configure_file("${__base}/${f}" "${__loader_path}/cv2/_extra_py_code/${f}" COPYONLY)
+          install(FILES "${__base}/${f}" DESTINATION "${OPENCV_PYTHON_INSTALL_PATH}/cv2/_extra_py_code/${f}" COMPONENT python)


So does it go to the target FS like this? Can it be.. compromised? Can we execute some privileged code while loading those scripts? If I get this right...

It goes into subdirectories (so these files can be modified iff all OpenCV files can be modified).
PYTHONPATH / sys.path may affect loaded scripts too, but this also can break import cv2 in the same way.

alalek · 2021-05-01T23:35:31Z

@mshabunin Please take a look on Python integration part.
Perhaps Python integration should be updated for OpenCV build of OpenVINO distribution too (switch from binary extension single file to loader package subdirectory, probably replaced with new one bootstrap file - because installation paths are "moved").

mshabunin · 2021-05-05T15:08:28Z

We've already enabled python loader in OpenCV for OpenVINO, but what about other distributions (conda, pip), will they work? I believe they do not use python loader. Maybe previous mechanism with C implementation in cv2.cpp should be restored? Or can it be done later?

TolyaTalamanov · 2021-05-12T06:27:13Z

@alalek @mshabunin What's the current status of this ? Can it be merged ?

TolyaTalamanov · 2021-05-19T22:08:03Z

modules/gapi/misc/python/pyopencv_gapi.hpp

    for (int i = 0; i < size; ++i)
    {
-        PyObject* pair   = PyTuple_GetItem(py_args, i);
-        PyObject* kernel = PyTuple_GetItem(pair, 0);
+        PyObject* user_kernel = PyTuple_GetItem(py_args, i);


Don't need to care about user_kernel utilization in case exception because PyTuple_GetItem return borrowed reference.

TolyaTalamanov · 2021-05-20T09:34:50Z

@alalek

…ration-api G-API: New python operations API * Reimplement test using decorators * Custom python operation API * Remove wip status * python: support Python code in bindings (through loader only) * cleanup, skip tests for Python 2.x (not supported) * python 2.x can't skip unittest modules * Clean up * Clean up * Fix segfault python3.9 Co-authored-by: Alexander Alekhin <[email protected]>

TolyaTalamanov added 2 commits April 20, 2021 13:02

Reimplement test using decorators

4353a78

Custom python operation API

7f4371f

TolyaTalamanov added the category: g-api / gapi label Apr 26, 2021

TolyaTalamanov commented Apr 26, 2021

View reviewed changes

modules/gapi/misc/python/package/gapi/init.py Outdated Show resolved Hide resolved

TolyaTalamanov commented Apr 26, 2021

View reviewed changes

modules/gapi/misc/python/package/gapi/init.py Outdated Show resolved Hide resolved

modules/python/src2/cv2.cpp Outdated Show resolved Hide resolved

modules/gapi/misc/python/test/test_gapi_sample_pipelines.py Outdated Show resolved Hide resolved

TolyaTalamanov requested review from alalek and dkurt April 26, 2021 14:01

Merge branch 'master' of https://github.com/opencv/opencv into at/new…

3d77c27

…-python-operation-api

TolyaTalamanov force-pushed the at/new-python-operation-api branch from 4aa708c to 3d77c27 Compare April 26, 2021 15:33

TolyaTalamanov commented Apr 26, 2021

View reviewed changes

Remove wip status

5f2cb08

alalek reviewed Apr 27, 2021

View reviewed changes

alalek and others added 5 commits April 27, 2021 20:50

python: support Python code in bindings (through loader only)

1cc2ca4

cleanup, skip tests for Python 2.x (not supported)

0b8328f

python 2.x can't skip unittest modules

92fd7bf

Merge branch 'master' of https://github.com/opencv/opencv into at/new…

bb8b4f3

…-python-operation-api

Clean up

4fd0a07

dkurt reviewed Apr 30, 2021

View reviewed changes

modules/gapi/misc/python/package/gapi/__init__.py Show resolved Hide resolved

dkurt approved these changes Apr 30, 2021

View reviewed changes

l-bat reviewed Apr 30, 2021

View reviewed changes

TolyaTalamanov requested a review from dmatveev April 30, 2021 09:39

Clean up

4a0ffc8

TolyaTalamanov force-pushed the at/new-python-operation-api branch from 670e281 to 4a0ffc8 Compare April 30, 2021 10:13

l-bat approved these changes Apr 30, 2021

View reviewed changes

dmatveev self-assigned this Apr 30, 2021

dmatveev approved these changes Apr 30, 2021

View reviewed changes

TolyaTalamanov force-pushed the at/new-python-operation-api branch from 8e771c1 to 8a55ab0 Compare May 19, 2021 22:09

TolyaTalamanov commented May 20, 2021

View reviewed changes

Fix segfault python3.9

1f44715

TolyaTalamanov force-pushed the at/new-python-operation-api branch from 8a55ab0 to 1f44715 Compare May 20, 2021 05:16

alalek approved these changes May 20, 2021

View reviewed changes

alalek merged commit c4df898 into opencv:master May 20, 2021

This was referenced Jun 4, 2021

(5.x) Merge 4.x #20216

Merged

cmake: fix installation of python extra code #20257

Merged

		@@ -522,5 +375,288 @@ def test_custom_op_goodFeaturesToTrack(self):
		np.array(actual, dtype=np.float32).flatten(), cv.NORM_INF))


		def test_invalid_op(self):

Uh oh!

G-API: New python operations API #19982

G-API: New python operations API #19982

Uh oh!

Conversation

TolyaTalamanov commented Apr 26, 2021

Pull Request Readiness Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TolyaTalamanov commented Apr 26, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshabunin commented Apr 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TolyaTalamanov commented Apr 27, 2021

Uh oh!

alalek left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dkurt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TolyaTalamanov commented Apr 30, 2021

Uh oh!

TolyaTalamanov commented Apr 30, 2021

Uh oh!

l-bat left a comment

Choose a reason for hiding this comment

Uh oh!

dmatveev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alalek commented May 1, 2021

Uh oh!

mshabunin commented May 5, 2021

Uh oh!

TolyaTalamanov commented May 12, 2021

mshabunin commented Apr 27, 2021 •

edited

Loading

alalek left a comment •

edited

Loading

dmatveev left a comment •

edited

Loading