Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mshabunin
Copy link
Contributor

@mshabunin mshabunin commented Mar 17, 2022

Resolves #21732

Raise an exception if one of sources is the same as one of destinations since inplace mode works incorrectly (with and without IPP).

allow_multiple_commits=1

}
}

using namespace ocl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary? used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think EXPECT_MAT_NEAR did not work without it. I'll check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked and it is EXPEC_MAT_NEAR which requires ocl namespace.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use related calls with full namespace in this macro?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Also rebased to 3.4.

@mshabunin mshabunin changed the base branch from 4.x to 3.4 March 21, 2022 13:10
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 0a62de0 into opencv:3.4 Mar 21, 2022
@vrabaud vrabaud mentioned this pull request Mar 24, 2022
4 tasks
@alalek alalek mentioned this pull request Mar 26, 2022
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
@mshabunin mshabunin deleted the fix-cart-polar branch July 10, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cartToPolar does not work in place

3 participants