-
-
Notifications
You must be signed in to change notification settings - Fork 56.3k
cartToPolar/polarToCart: disable inplace mode #21739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modules/core/test/test_arithm.cpp
Outdated
} | ||
} | ||
|
||
using namespace ocl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary? used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think EXPECT_MAT_NEAR
did not work without it. I'll check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked and it is EXPEC_MAT_NEAR
which requires ocl
namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use related calls with full namespace in this macro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Also rebased to 3.4.
aa3c55e
to
69822cf
Compare
69822cf
to
5939962
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Resolves #21732
Raise an exception if one of sources is the same as one of destinations since inplace mode works incorrectly (with and without IPP).