Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

fengyuentau
Copy link
Member

@fengyuentau fengyuentau commented Mar 19, 2022

Related PR: #21036
Docker image used for x86_64 simulator: https://hub.docker.com/r/yuentau/ocv_ubuntu
A running sample of this workflow on my fork: https://github.com/fengyuentau/opencv/actions/runs/2003773534

The yaml file must be on the default branch for GitHub to pick up and run the workflow. I propose to add the condition if for the two jobs before the PR for TIM-VX backend is merged. In this case, a new label "category:dnn_timvx" needs to be created for pull requests.

Also we need to add the Khadas VIM3 as the self-hosted runner to run the second job, which requires some operations by the admin.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

x86-simulator-build-test:
if: contains(github.event.pull_request.labels.*.name, 'category:dnn_timvx')
runs-on: ubuntu-20.04
container: yuentau/ocv_ubuntu:20.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yuentau/ocv_ubuntu:20.04

Where is stored?
How is it generated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference added. Dockerfile can be accessed in the overview section of the linked Docker Hub repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make the source more clear: container: docker.io/yuentau/ocv_ubuntu:20.04. It works as the same with the one without docker.io/ prefix. You can verify by checking 'Initialize containers' from my test https://github.com/fengyuentau/github-actions-tests/runs/5653954490?check_suite_focus=true

@@ -0,0 +1,104 @@
name: TIM-VX Backend
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/extra_tests.yml

Need to rename "extra_tests"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to "timvx_backend_tests.yml". Or any suggestions?

@alalek alalek merged commit b379b67 into opencv:4.x Apr 1, 2022
@fengyuentau fengyuentau deleted the add_github_actions_for_timvx_backend branch April 3, 2022 10:12
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
…or_timvx_backend

CI for TIM-VX backend

* github actions for TIM-VX backend opencv#21036

* add reference to yuentau/ocv_ubuntu:20.04; remove extra quotes; enable BUILD_TESTS

* rename to timvx_backend_tests.yml

* add image source prefix

* remove if condition for x86_64 simulator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: dnn CI/CD: GitHub Actions (GHA) Changes related to CI/CD pipelines (GitHub Actions)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants