Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reduce G-API tests number #21909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 15, 2022
Merged

Reduce G-API tests number #21909

merged 4 commits into from
May 15, 2022

Conversation

dbudnikov
Copy link
Contributor

@dbudnikov dbudnikov commented Apr 25, 2022 •
edited by opencv-pushbot
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
Xforce_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.4.1:20.04
build_image:Custom Win=openvino-2021.4.1
build_image:Custom Mac=openvino-2021.4.1

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@dbudnikov dbudnikov requested a review from dmatveev April 25, 2022 13:09
@dbudnikov
Copy link
Contributor Author

These changes reduce overall number of G-API tests by ~25% and overall G-API test suite execution time by ~20%.

dmatveev
dmatveev approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we still have cases with multiple resolutions, I'd propose to declare a constant vector of the sizes once and for all tests - and use ValuesIn(...) in the test instantiations

modules/gapi/test/cpu/gapi_core_tests_fluid.cpp
Comment on lines 21 to 23
Values(cv::Size(1920, 1080),
cv::Size(1280, 720),
cv::Size(640, 480),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This selection looks strange. Shouldn't the 1080 option be removed & 720 be kept as in the previous file?
As far I can see, the below cases also instantiate 720 and not 1080.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

modules/gapi/test/cpu/gapi_core_tests_fluid.cpp Outdated
Comment on lines 243 to 244
Values(cv::Size(1920, 1080),
cv::Size(1280, 720),
cv::Size(640, 480),
cv::Size(128, 128)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should declare the list of resolutions we test one and for all the tests? Then ValuesIn(...) could be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dmatveev dmatveev self-assigned this Apr 29, 2022
@dmatveev dmatveev added this to the 4.6.0 milestone Apr 29, 2022
@dbudnikov dbudnikov force-pushed the dbudnikov/reduce_gapi_tests_number branch from ebed694 to 18ca503 Compare May 6, 2022 14:41
@dbudnikov dbudnikov force-pushed the dbudnikov/reduce_gapi_tests_number branch from 18ca503 to 1f9882b Compare May 12, 2022 16:48
@alalek alalek merged commit 3f4ffe7 into opencv:4.x May 15, 2022
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@dbudnikov
Merge pull request opencv#21909 from dbudnikov:dbudnikov/reduce_gapi_…
3a1b42d 
…tests_number

Reduce G-API tests number

* reduce number of G-API tests

* reduce number of G-API tests

* Address more comments from Dmitry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi test

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dbudnikov @dmatveev @opencv-pushbot @alalek