Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Small imencode documentation improvement #21954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

Small imencode documentation improvement #21954

merged 1 commit into from
May 12, 2022

Conversation

Darkyenus
Copy link
Contributor

It was previously not clear that the extension should include the period, and I am not the only person that encountered this problem.

I assume that this is true for all supported extensions, but I haven't checked the source.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added category: documentation Documentation fix or update pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch labels May 11, 2022
@asmorkalov
Copy link
Contributor

Thanks a lot for the contribution! Please rebase you branch to 3.4 and retarget the pr. The fix will be merged to 4.x and 5.x by the OpenCV team.

@Darkyenus Darkyenus changed the base branch from master to 3.4 May 11, 2022 09:52
@Darkyenus
Copy link
Contributor Author

Darkyenus commented May 11, 2022 •
edited
Loading

Oops, doing it in the web interface messed it up, I'll fix it up manually.

@Darkyenus
Small imencode documentation improvement
dea0815 
It was previously not clear that the extension should include the period, [and I am not the only person that encountered this problem](https://stackoverflow.com/questions/4254460/opencv-could-not-find-encoder-for-the-specified-extension).

I assume that this is true for all supported extensions, but I haven't checked the source.
@Darkyenus
Copy link
Contributor Author

Should be fixed now.

@asmorkalov asmorkalov removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label May 11, 2022
@asmorkalov asmorkalov self-requested a review May 11, 2022 13:30
@opencv-pushbot opencv-pushbot added this to the 3.4.18 milestone May 12, 2022
@opencv-pushbot opencv-pushbot merged commit 0ef1fb0 into opencv:3.4 May 12, 2022
@Darkyenus Darkyenus deleted the patch-1 branch May 12, 2022 14:34
@opencv-pushbot opencv-pushbot mentioned this pull request May 14, 2022
Merged
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@opencv-pushbot opencv-pushbot

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.18

Development

Successfully merging this pull request may close these issues.

3 participants

@Darkyenus @asmorkalov @opencv-pushbot