Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move from https to ssh for Windows in Github Actions #21975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2022
Merged

Move from https to ssh for Windows in Github Actions #21975

merged 1 commit into from
May 13, 2022

Conversation

asenyaev
Copy link
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asenyaev asenyaev added the CI/CD: GitHub Actions (GHA) Changes related to CI/CD pipelines (GitHub Actions) label May 12, 2022
asmorkalov
asmorkalov approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fengyuentau
Copy link
Member

May I ask why use SSH protocol instead of HTTPS?

@asenyaev
Copy link
Contributor Author

May I ask why use SSH protocol instead of HTTPS?

In case of the command git ls-remote --heads ... asks for a username and a password any time with HTTPS and Windows builds can stuck on this simple check (for example), but SSH doesn't ask for credentials.

By the way, I would replace this implementation with something similar as it is in buildbot. In addition, we had used curl to check a branch in other repo in Jenkins.

@fengyuentau
Copy link
Member

Thank you for the explanation👍

@opencv-pushbot opencv-pushbot added this to the 3.4.18 milestone May 13, 2022
@opencv-pushbot opencv-pushbot merged commit 53f0be0 into opencv:3.4 May 13, 2022
@opencv-pushbot opencv-pushbot mentioned this pull request May 14, 2022
Merged
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@fengyuentau fengyuentau fengyuentau approved these changes

Assignees

@opencv-pushbot opencv-pushbot

Labels

CI/CD: GitHub Actions (GHA) Changes related to CI/CD pipelines (GitHub Actions)

Projects

None yet

Milestone

3.4.18

Development

Successfully merging this pull request may close these issues.

4 participants

@asenyaev @fengyuentau @asmorkalov @opencv-pushbot