Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix cameracalibration test #22019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2022
Merged

Fix cameracalibration test #22019

merged 1 commit into from
May 30, 2022

Conversation

victor1234
Copy link
Contributor

@victor1234 victor1234 commented May 23, 2022 •
edited
Loading

  • Remove transpose for rvec after calibration
  • Change compare threshold from 110% to 10% for perViewErrors
  • Add transpose to goodRotMatrs load

#19849
#20810

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@victor1234
Fix cameracalibration test
50bf0e1 
* Remove transpose for rvec after calibration
* Change compare threshold from 110% to 10% for perViewErrors
* Add transpose to goodRotMatrs load
@victor1234 victor1234 self-assigned this May 23, 2022
@victor1234 victor1234 mentioned this pull request May 23, 2022
Closed
6 tasks
@victor1234 victor1234 marked this pull request as ready for review May 23, 2022 12:13
@victor1234 victor1234 requested a review from asmorkalov May 23, 2022 12:14
@asmorkalov asmorkalov requested a review from vpisarev May 23, 2022 13:16
@alalek alalek assigned asmorkalov and unassigned victor1234 May 30, 2022
@opencv-pushbot opencv-pushbot merged commit d6151ea into opencv:4.x May 30, 2022
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

@asmorkalov asmorkalov

Labels

bug category: calib3d test

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@victor1234 @asmorkalov @opencv-pushbot @alalek