Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DRY (don't repeat yourself) #22232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2022
Merged

DRY (don't repeat yourself) #22232

merged 1 commit into from
Jul 12, 2022

Conversation

tomoaki0705
Copy link
Contributor

closes #22231

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

alalek
alalek reviewed Jul 12, 2022
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the first 3 changes are harmless. Others are probably not.

modules/python/CMakeLists.txt Outdated
else() # standalone build

cmake_minimum_required(VERSION 2.8.12)
cmake_minimum_required(VERSION ${MIN_VER_CMAKE})
Copy link
Member

@alalek alalek Jul 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standalone

MIN_VER_CMAKE may be not available for standalone bindings, samples, hal samples.

Let keep/put 2.8.12 for these cases to avoid warning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets bump to 2.8.12 for other cases to avoid warning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took this "other cases" as standalone bindings, samples and hal samples.
I also bumped ones in the "toolchain.cmake" in platform directory, please let me know if that's along with your expectation.

Only remaining cmake_minimum_required that I didn't touch is the one in the doc directory

@tomoaki0705
build: suppress the warning
87ef6a9 
DRY
bump the version
alalek
alalek approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 2a82467 into opencv:3.4 Jul 12, 2022
@tomoaki0705 tomoaki0705 deleted the dryCmake branch July 12, 2022 21:01
@alalek alalek mentioned this pull request Jul 26, 2022
Closed
This was referenced Aug 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: build/install

Projects

None yet

Milestone

3.4.19

Development

Successfully merging this pull request may close these issues.

3 participants

@tomoaki0705 @alalek @opencv-pushbot