correct an issue of trackbar on macOS #22255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2d3
commented
Jul 15, 2022
modules/highgui/src/window_cocoa.mm
Outdated
| if (value) | ||
| text = [NSString stringWithFormat:@"%@ %d", temp, *value]; | ||
| else | ||
| text = [NSString stringWithFormat:@"%@ %d", temp, pos]; |
There was a problem hiding this comment.
Perhaps we could use only this case ?
Is there use case where the user fill *value with the value he wants to be displayed ?
There was a problem hiding this comment.
Lets just replace *value -> pos unconditionally.
-NSString *text = [NSString stringWithFormat:@"%@ %d", temp, *value];
+NSString *text = [NSString stringWithFormat:@"%@ %d", temp, pos];relates #22047
alalek
reviewed
Jul 15, 2022
modules/highgui/src/window_cocoa.mm
Outdated
| if (value) | ||
| text = [NSString stringWithFormat:@"%@ %d", temp, *value]; | ||
| else | ||
| text = [NSString stringWithFormat:@"%@ %d", temp, pos]; |
There was a problem hiding this comment.
Lets just replace *value -> pos unconditionally.
-NSString *text = [NSString stringWithFormat:@"%@ %d", temp, *value];
+NSString *text = [NSString stringWithFormat:@"%@ %d", temp, pos];relates #22047
Python binding is passing NULL as (int*)value. sliderChanged crash when trying to dereference value
74b9467 to
60846b2
Compare
alalek
approved these changes
Jul 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python binding is passing NULL as (int*)value.
sliderChanged crash when trying to dereference value
A user reported this issue to me on IRC and opened an issue in opencv-python
opencv/opencv-python#691
I have a solution for the issue but I do not know which OpenCV branch I should target
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.