Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

hanliutong
Copy link
Contributor

@hanliutong hanliutong commented Jul 21, 2022

This pull request is going to fix compile errors when 1. all SIMD backend is disabled (aka. using cpp backend) and 2. using RVV backend.

  1. The main modification is using #if !CV_SIMD_SCALABLE instead of #if CV_SIMD in the universal intrinsic compatibility layer. And some necessary head file are added to eliminate errors in when all SIMD is disabled.
    Test with RVV, AVX and cpp backend.
    Related PR : [GSoC] New universal intrinsic backend for RVV #22179

  2. Another modification is using #if instead of #ifdef for CV_SIMD128.
    Because #ifdef CV_SIMD128 will be True when CV_SIMD128 is defined as 0, which is unexpected and will cause an error in the RVV backend.
    Related PR : DNN: Accelerating convolution #21910

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Linux Debug
allow_multiple_commits=1

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@opencv-pushbot opencv-pushbot merged commit 47f30a0 into opencv:4.x Jul 22, 2022
@alalek
Copy link
Member

alalek commented Jul 23, 2022

Please take a look on build issues for Win32 build configuration (MSVS 2015): https://pullrequest.opencv.org/buildbot/builders/precommit_windows32/builds/100053

@alalek
Copy link
Member

alalek commented Jul 23, 2022

Win64 (MSVS 2015) build issues are here: https://pullrequest.opencv.org/buildbot/builders/precommit_windows64/builds/100064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants