Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix in obsensor for VS 14 #22339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2022
Merged

Fix in obsensor for VS 14 #22339

merged 1 commit into from
Aug 5, 2022

Conversation

asenyaev
Copy link
Contributor

@asenyaev asenyaev commented Aug 3, 2022 •
edited
Loading

This PR fixes a build on Windows using Visual Studio 14 (it works with VS 16 somehow).

Relates to #22196

Pipelines before changes:

Pipelines after changes:

Thanks @rogday for the help!

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asenyaev
Copy link
Contributor Author

asenyaev commented Aug 3, 2022

@hzcyf, please, take a look.

rogday
rogday approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

zihaomu
zihaomu approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@asmorkalov asmorkalov removed their request for review August 5, 2022 06:58
@opencv-pushbot opencv-pushbot merged commit 8855594 into opencv:4.x Aug 5, 2022
@asenyaev asenyaev deleted the asen/obsensor_fix_for_win branch August 6, 2022 09:51
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zihaomu zihaomu zihaomu approved these changes

+1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zihaomu zihaomu

Labels

category: build/install category: videoio platform: win32

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@asenyaev @zihaomu @rogday @opencv-pushbot @asmorkalov