Thanks to visit codestin.com
Credit goes to github.com

Skip to content

videoio: Include missing condition_variable header #22377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2022
Merged

videoio: Include missing condition_variable header #22377

merged 1 commit into from
Aug 18, 2022

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Aug 14, 2022 •
edited by alalek
Loading 

This fixes the following error with mingw toolchain:
opencv/modules/videoio/src/cap_obsensor/obsensor_stream_channel_msmf.hpp:160:10: error: 'condition_variable' in namespace 'std' does not name a type
  160 |     std::condition_variable streamStateCv_;
      |          ^~~~~~~~~~~~~~~~~~

relates #22196

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Biswa96
videoio: Include missing condition_variable header
c2c539e 
This fixes the following error with mingw toolchain:
opencv/modules/videoio/src/cap_obsensor/obsensor_stream_channel_msmf.hpp:160:10: error: 'condition_variable' in namespace 'std' does not name a type
  160 |     std::condition_variable streamStateCv_;
      |          ^~~~~~~~~~~~~~~~~~
@berak
Copy link
Contributor

berak commented Aug 14, 2022

hey, great !
if you came that far, maybe you can append to the discussion here ?

@asmorkalov asmorkalov requested a review from zihaomu August 15, 2022 08:40
@zihaomu
Copy link
Member

zihaomu commented Aug 18, 2022

Hi, @Biswa96. Thanks for your contribution!
Question: is this header file only needed by MinGW?

@Biswa96
Copy link
Contributor Author

Biswa96 commented Aug 18, 2022

No, this is not for mingw only. There is std::condition_variable streamStateCv_ variable which needs the condition_variable header. C++ standard says so https://en.cppreference.com/w/cpp/thread/condition_variable

zihaomu
zihaomu approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@opencv-pushbot opencv-pushbot merged commit 7deb8f5 into opencv:4.x Aug 18, 2022
@Biswa96 Biswa96 deleted the condition_variable branch August 18, 2022 12:04
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zihaomu zihaomu zihaomu approved these changes

Assignees

@zihaomu zihaomu

Labels

category: videoio(camera) platform: win32

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Biswa96 @berak @zihaomu @opencv-pushbot @asmorkalov