Thanks to visit codestin.com
Credit goes to github.com

Skip to content

videoio: Include missing locale header for std::wstring_convert #22403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2022
Merged

videoio: Include missing locale header for std::wstring_convert #22403

merged 1 commit into from
Aug 19, 2022

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Aug 19, 2022 

This fixes the following error with mingw toolchain:
opencv/modules/videoio/src/cap_msmf.cpp:1020: error: 'wstring_convert' is not a member of 'std'
 1020 |                                     std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> conv;
      |                                          ^~~~~~~~~~~~~~~
opencv/modules/videoio/src/cap_ffmpeg_hw.hpp:230:26: error: 'wstring_convert' is not a member of 'std'
  230 |                     std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> conv;
      |                          ^~~~~~~~~~~~~~~

The locale header is required according to C++ standard.
See https://en.cppreference.com/w/cpp/locale/wstring_convert

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Biswa96
videoio: Include missing locale header for std::wstring_convert
984e42b 
This fixes the following error with mingw toolchain:
opencv/modules/videoio/src/cap_msmf.cpp:1020: error: 'wstring_convert' is not a member of 'std'
 1020 |                                     std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> conv;
      |                                          ^~~~~~~~~~~~~~~
opencv/modules/videoio/src/cap_ffmpeg_hw.hpp:230:26: error: 'wstring_convert' is not a member of 'std'
  230 |                     std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> conv;
      |                          ^~~~~~~~~~~~~~~

The locale header is required according to C++ standard.
See https://en.cppreference.com/w/cpp/locale/wstring_convert
@asmorkalov asmorkalov requested a review from zihaomu August 19, 2022 07:48
@Biswa96
Copy link
Contributor Author

Biswa96 commented Aug 19, 2022

std::wstring_convert is called if HAVE_D3D11or HAVE_MSMF_DXVA is defined. So, I include locale header under those conditions. I'm not sure if it should be included globally.

@vpisarev
Copy link
Contributor

@asmorkalov, to me adding standard #include looks innocent. Let's merge it.

zihaomu
zihaomu approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 👍

@opencv-pushbot opencv-pushbot merged commit e14c3cf into opencv:4.x Aug 19, 2022
@Biswa96 Biswa96 deleted the add-locale-header branch August 19, 2022 10:09
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zihaomu zihaomu zihaomu approved these changes

Assignees

@zihaomu zihaomu

Labels

category: build/install platform: win32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Biswa96 @vpisarev @zihaomu @opencv-pushbot @asmorkalov