Thanks to visit codestin.com
Credit goes to github.com

Skip to content

OAK Information #22501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2022
Merged

OAK Information #22501

merged 2 commits into from
Oct 4, 2022

Conversation

cabelo
Copy link
Contributor

@cabelo cabelo commented Sep 12, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from dmatveev September 12, 2022 05:06
@asmorkalov asmorkalov added category: documentation Documentation fix or update category: t-api cv::UMat related issues labels Sep 12, 2022
asmorkalov
asmorkalov reviewed Sep 12, 2022
View reviewed changes
doc/tutorials/gapi/oak_devices/oak_devices.markdown Outdated
Depth sensors compatible with DepthAI library are supported through OpenCV Graph API (or G-API) module. Depth map, RGB image and some other formats of output can be retrieved by using familiar interface of G-API module.

In order to use DepthAI sensor with OpenCV you should do the following preliminary steps:
-# Install Intel DepthAI library/depthai-core (from here <https://github.com/luxonis/depthai-core>).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luxonis DepthAI library

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it has been resolved?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cabelo Intel -> Luxonis. Also it makes sense to use markdown notation for the link.

@asmorkalov
Copy link
Contributor

@cabelo Please resolve CI warnings: https://pullrequest.opencv.org/buildbot/builders/precommit_docs/builds/101063/steps/make%20doxygen/logs/warnings%20%281%29

/build/precommit_docs/4.x/opencv/doc/tutorials/gapi/table_of_content_gapi.markdown:47: warning: unable to resolve reference to `tutorial_gapi_oak_devices' for \ref command

@cabelo
Copy link
Contributor Author

cabelo commented Sep 12, 2022

@cabelo Please resolve CI warnings: https://pullrequest.opencv.org/buildbot/builders/precommit_docs/builds/101063/steps/make%20doxygen/logs/warnings%20%281%29

/build/precommit_docs/4.x/opencv/doc/tutorials/gapi/table_of_content_gapi.markdown:47: warning: unable to resolve reference to `tutorial_gapi_oak_devices' for \ref command

Sorry done.

@cabelo
Copy link
Contributor Author

cabelo commented Sep 12, 2022

@cabelo Please resolve CI warnings: https://pullrequest.opencv.org/buildbot/builders/precommit_docs/builds/101063/steps/make%20doxygen/logs/warnings%20%281%29

/build/precommit_docs/4.x/opencv/doc/tutorials/gapi/table_of_content_gapi.markdown:47: warning: unable to resolve reference to `tutorial_gapi_oak_devices' for \ref command

done

@cabelo cabelo requested review from asmorkalov and removed request for dmatveev September 13, 2022 08:49
@cabelo
Copy link
Contributor Author

cabelo commented Sep 13, 2022

@cabelo Please resolve CI warnings: https://pullrequest.opencv.org/buildbot/builders/precommit_docs/builds/101063/steps/make%20doxygen/logs/warnings%20%281%29

/build/precommit_docs/4.x/opencv/doc/tutorials/gapi/table_of_content_gapi.markdown:47: warning: unable to resolve reference to `tutorial_gapi_oak_devices' for \ref command

done

@dmatveev I removed you from the request unintentionally. sorry

@asmorkalov asmorkalov requested a review from dmatveev September 13, 2022 11:21
@cabelo
Copy link
Contributor Author

cabelo commented Sep 14, 2022

@dmatveev I

@dmatveev Are you ok with the request now? thanks for the support

dmatveev
dmatveev reviewed Sep 15, 2022
View reviewed changes
Copy link
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cabelo for your contribution!

While this tutorial might be a good starting point, there's a number of points how it can be improved to bring more value to the users:

  1. See comments for the changeset
  2. Ideally we need to explain what happens here, and what can & can't be done with the OAK backend. Why do we need copy, why there's a certain camera input source needs to be used, etc. Let @smirnov-alexey help with that

-Dmitry

@smirnov-alexey
Copy link
Contributor

Hi @cabelo! Thanks for your contribution! There are some things to consider here:

  1. Currently OAK backends have some limitations on what it can do and how it should be properly used (e.g. copy operation for taking camera output, copy operation for heterogeneous graphs (OAK + CPU interaction), etc). If you are interested in extending the tutorial with that, please let me know
  2. oak_copy.cpp is ok as a snippet but it's rather basic. I suggest to consider oak_basic_infer.cpp instead

@cabelo
Copy link
Contributor Author

cabelo commented Sep 15, 2022

Hi @cabelo! Thanks for your contribution! There are some things to consider here:

1. Currently OAK backends have some limitations on what it can do and how it should be properly used (e.g. `copy` operation for taking camera output, `copy` operation for heterogeneous graphs (OAK + CPU interaction), etc). If you are interested in extending the tutorial with that, please let me know

2. `oak_copy.cpp` is ok as a snippet but it's rather basic. I suggest to consider `oak_basic_infer.cpp` instead

@smirnov-alexey Thanks for the support, I changed the example to oak_basic_infer.cpp

Can we close this request like this?

I'm interested in extending the tutorial in next request ok?

@cabelo
Copy link
Contributor Author

cabelo commented Sep 20, 2022

@dmatveev have something else to do?

@cabelo
Copy link
Contributor Author

cabelo commented Sep 22, 2022

@dmatveev have something else to do?

@smirnov-alexey have something else to do?

smirnov-alexey
smirnov-alexey reviewed Sep 22, 2022
View reviewed changes
@smirnov-alexey
Copy link
Contributor

@dmatveev have something else to do?

@smirnov-alexey have something else to do?

Hi @cabelo there are some minor fixes left. However, I still think that tutorial could be extended (explaining copy operation, inference, etc). If @dmatveev is OK with this PR we could merge it and extend the tutorial later, but for now it barely helps any user to understand and properly utilize G-API's OAK backend

dmatveev
dmatveev approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was away for quite a while. Sure I am fine with the tutor now. Thanks a lot!

@asmorkalov
Copy link
Contributor

@cabelo Please squash the commits before merge.

cabelo
cabelo commented Oct 3, 2022
View reviewed changes
Copy link
Contributor Author

@cabelo cabelo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done... Thanks @asmorkalov

@dmatveev dmatveev added category: g-api / gapi and removed category: t-api cv::UMat related issues labels Oct 4, 2022
@asmorkalov
Copy link
Contributor

@cabelo I squashed commits and fixed several formatting issues and typos. Will merge the final PR soon.

@asmorkalov asmorkalov merged commit b77330b into opencv:4.x Oct 4, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smirnov-alexey smirnov-alexey smirnov-alexey left review comments

@dmatveev dmatveev dmatveev approved these changes

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@dmatveev dmatveev

Labels

category: documentation Documentation fix or update category: g-api / gapi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cabelo @asmorkalov @smirnov-alexey @dmatveev