Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.4] Add information about the disparity-to-depth mapping matrix #22572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2022
Merged

[3.4] Add information about the disparity-to-depth mapping matrix #22572

merged 1 commit into from
Sep 27, 2022

Conversation

catree
Copy link
Contributor

@catree catree commented Sep 26, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

About the Q matrix:

opencv/modules/calib3d/src/calibration.cpp

Lines 2755 to 2762 in a682f02

double q[] =
{
1, 0, 0, -cc_new[0].x,
0, 1, 0, -cc_new[0].y,
0, 0, 0, fc_new,
0, 0, -1./_t[idx],
(idx == 0 ? cc_new[0].x - cc_new[1].x : cc_new[0].y - cc_new[1].y)/_t[idx]
};

Add also references to related functions since in my opinion it is preferable to have html links for related functions.

To be ported to the 4.x branch.
I can open a dedicated pull request if it is preferable, just tell me.

@catree
Add information about the disparity-to-depth mapping matrix. Add more…
c34c4b5 
… references about other related functions in the calib3d doc.
@asmorkalov asmorkalov self-requested a review September 27, 2022 06:56
@asmorkalov asmorkalov self-assigned this Sep 27, 2022
asmorkalov
asmorkalov reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot for the contribution!

@asmorkalov
Copy link
Contributor

Checked manually with local html docs build.

@asmorkalov asmorkalov merged commit 4dfbbab into opencv:3.4 Sep 27, 2022
alalek
alalek reviewed Oct 8, 2022
View reviewed changes
modules/calib3d/include/opencv2/calib3d.hpp
@param Qz Optional output 3x3 rotation matrix around z-axis.
The function computes a RQ decomposition using the given rotations. This function is used in
decomposeProjectionMatrix to decompose the left 3x3 submatrix of a projection matrix into a camera
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the merge of this PR we need to define policy how to provide documentation links.
And avoid mess between # and @ref (and related merge conflicts).

4.x branch has links already through #:

This was referenced Oct 13, 2022
Merged
Merged
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@asmorkalov asmorkalov added this to the 3.4.19 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: calib3d category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.19

Development

Successfully merging this pull request may close these issues.

3 participants

@catree @asmorkalov @alalek