optimize winograd futher more #22593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3737175 to
7abc664
Compare
5e07441 to
98ae058
Compare
|
@zihaomu Could you run perf test with 4.x and your branch and attach results to the PR. ARM and some AMD/Intel CPU performance numbers will be useful. |
|
Hi @asmorkalov, the performance test has been updated. |
98ae058 to
0fa43e3
Compare
vpisarev
approved these changes
Oct 19, 2022
|
Debug builds (no optimization) are broken: http://pullrequest.opencv.org/buildbot/builders/master_noOCL_noICV_noSSE-lin64-debug/builds/100001 |
|
Hi @alalek, thanks for pointing out this. It's my mistake. I will try to fix it as soon as possible. |
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is proposed for optimizing the winograd futher more. Support the Winograd branch on AVX2 and NEON and Universal intrinsic.
The original code comes from: https://github.com/vpisarev/ficus/blob/master/lib/NN/OpConv_Winograd.fx.
It should be noted that the existing Winograd only supports NEON. This path not only improves the speed of Winograd on NEON, but also adds the Winograd support of AVX2 and Universal intrinsic.
Performance Test based on ResNet50 float32
Test Details: Run the model 1000 times, choose the minimum time.
TODO List
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.