Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DNN: Make Unsqueeze layer support negative axes #22639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

DNN: Make Unsqueeze layer support negative axes #22639

merged 1 commit into from
Oct 17, 2022

Conversation

WanliZhong
Copy link
Member

Merge with extra: opencv/opencv_extra#1012

This PR try to fix #22625
ONNX operator doc: https://github.com/onnx/onnx/blob/main/docs/Operators.md#unsqueeze

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@WanliZhong WanliZhong mentioned this pull request Oct 14, 2022
Merged
@WanliZhong WanliZhong added category: dnn category: dnn (onnx) ONNX suport issues in DNN module labels Oct 14, 2022
@WanliZhong WanliZhong changed the title Make Unsqueeze layer support negative axes DNN: Make Unsqueeze layer support negative axes Oct 14, 2022
@WanliZhong
Copy link
Member Author

@alalek Hi, I'm confused why the test model I uploaded in opencv_extra doesn't work automatically in this PR's tests?

rogday
rogday approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fengyuentau
fengyuentau approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 1c5dcbc into opencv:4.x Oct 17, 2022
@WanliZhong WanliZhong deleted the issue#22625 branch October 18, 2022 03:07
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengyuentau fengyuentau fengyuentau approved these changes

+1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: dnn (onnx) ONNX suport issues in DNN module category: dnn

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

Loading Yolox model - Assertion failed) idx <= dims.size() in function 'parseUnsqueeze'

4 participants

@WanliZhong @fengyuentau @rogday @asmorkalov