Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cosmetic changes #22643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

cosmetic changes #22643

merged 1 commit into from
Oct 17, 2022

Conversation

sturkmen72
Copy link
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@sturkmen72
Copy link
Contributor Author

CMake output

before patch:

libjpeg-turbo: VERSION = 2.1.3, BUILD = opencv-4.6.0-dev-libjpeg-turbo
64-bit build (x86_64)
The ASM_NASM compiler identification is NASM
Found assembler: C:/Program Files/NASM/nasm.exe
CMAKE_ASM_NASM_COMPILER = C:/Program Files/NASM/nasm.exe
CMAKE_ASM_NASM_OBJECT_FORMAT = win64
CMAKE_ASM_NASM_FLAGS =  -DWIN64 -D__x86_64__ 
SIMD extensions: x86_64 (WITH_SIMD = 1)

after patch:

libjpeg-turbo: VERSION = 2.1.3, BUILD = opencv-4.6.0-dev-libjpeg-turbo
CMAKE_ASM_NASM_COMPILER = C:/Program Files/NASM/nasm.exe
SIMD extensions: x86_64 (WITH_SIMD = 1)

Visual Studio Solution Explorer after patch:
image

@asmorkalov asmorkalov self-requested a review October 17, 2022 09:24
asmorkalov
asmorkalov approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot!

@asmorkalov asmorkalov merged commit c0c3f4c into opencv:4.x Oct 17, 2022
@sturkmen72 sturkmen72 deleted the cosmetic branch October 17, 2022 14:07
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

No one assigned

Labels

category: build/install category: 3rdparty

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sturkmen72 @asmorkalov @alalek