DNN: report an error at the infinite loop of tensorflow importer #22725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Hi, should I add the test file supplied at issue #22709? |
alalek
reviewed
Oct 31, 2022
| IdentityOpsMap::iterator it = identity_ops.find(input_op_name); | ||
|
|
||
| if (it != identity_ops.end()) { | ||
| std::vector<IdentityOpsMap::iterator> itVec; |
There was a problem hiding this comment.
What is observed size of this container for valid models?
If it is a large (>50 items) then we should try std::set here.
itVec -> loopCheck / duplicateCheck / other descriptive name.
There was a problem hiding this comment.
Thanks for your code review.
Different models may have different itVec sizes. Since it just put the item in identity_ops to itVec, the size of identity_ops is the max number.
From my point of view, the maximum size of identity_ops should be less than 50. I agree with you, the std::set should be more reasonable.
f2b1889 to
18fbb72
Compare
alalek
approved these changes
Oct 31, 2022
|
@zihaomu could you port the solution back to 3.4 too? |
|
@asmorkalov sure. I'm working on it. |
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #22709
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.