ocl_minMaxIdx to call minmaxloc.cl for OpenCL 1.2+ only #22865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalek
requested changes
Nov 26, 2022
modules/core/src/minmax.cpp
Outdated
| CV_Assert( (cn == 1 && (_mask.empty() || _mask.type() == CV_8U)) || | ||
| (cn > 1 && _mask.empty() && !minIdx && !maxIdx) ); | ||
|
|
||
| #if defined(CL_VERSION_1_2) |
There was a problem hiding this comment.
This doesn't work in this way.
You have disabled OpenCL call everywhere.
alalek
approved these changes
Dec 3, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
naive change for the #22860 issue (but untested since I don't have OpenCL 1.1 here)
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.