Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move Aruco tutorials and samples to main repo #23018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 26, 2024
Merged

Move Aruco tutorials and samples to main repo #23018

merged 14 commits into from
Feb 26, 2024

Conversation

@stopmosk
Copy link
Contributor

@stopmosk stopmosk commented Dec 22, 2022 •
edited by AleksandrPanov
Loading

merge with opencv/opencv_contrib#3401
merge with opencv/opencv_extra#1143

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
**WIP**
force_builders=linux,docs
build_contrib:Docs=OFF

alalek
alalek reviewed Dec 22, 2022
View reviewed changes
asmorkalov
asmorkalov reviewed Dec 23, 2022
View reviewed changes
@AleksandrPanov AleksandrPanov mentioned this pull request Dec 24, 2023
Merged
6 tasks
@AleksandrPanov AleksandrPanov mentioned this pull request Jan 17, 2024
Merged
@AleksandrPanov AleksandrPanov marked this pull request as draft January 17, 2024 21:17
@AleksandrPanov AleksandrPanov force-pushed the move-aruco-tutorial branch 3 times, most recently from ed660d5 to bf8a61d Compare January 22, 2024 10:26
extra images have been removed, fix tutorials, update docs, optimized…
1378416 
… images, refactoring docs, update snippets
asmorkalov
asmorkalov reviewed Jan 23, 2024
View reviewed changes
@asmorkalov asmorkalov marked this pull request as ready for review January 23, 2024 12:46
@asmorkalov
Copy link
Contributor

asmorkalov commented Jan 23, 2024

General comment:
refineDetectedMarkers, detectMarkers and others are class methods, but not free functions. Need to fix wording.

asmorkalov
asmorkalov reviewed Jan 23, 2024
View reviewed changes
asmorkalov
asmorkalov reviewed Jan 23, 2024
View reviewed changes
@asmorkalov
Copy link
Contributor

asmorkalov commented Jan 23, 2024

I propose to replace png images with jpg to reduce patch size.

@asmorkalov asmorkalov added this to the 4.10.0 milestone Jan 23, 2024
@AleksandrPanov
Copy link
Contributor

AleksandrPanov commented Feb 20, 2024

General comment: refineDetectedMarkers, detectMarkers and others are class methods, but not free functions. Need to fix wording.

fixed

@AleksandrPanov
Copy link
Contributor

AleksandrPanov commented Feb 20, 2024

I propose to replace png images with jpg to reduce patch size.

The remaining PNG images are smaller than the JPG images.

asmorkalov
asmorkalov reviewed Feb 21, 2024
View reviewed changes
@asmorkalov
Copy link
Contributor

asmorkalov commented Feb 21, 2024

General notes:

  • please add standard pre-phrase with text author, compatible OpenCV version, etc.
  • not all images are converted to jpeg. I propose to convert intermediate images with contours to jpeg too.
  • need to update images with axes where behaviour is changed. M.b. need to mention the change (opencv version and previous behaviour) as @note.

@AleksandrPanov
Copy link
Contributor

AleksandrPanov commented Feb 22, 2024

Added new image for board with occlusions:

gbocclusion

original
original_gbocclusion

asmorkalov
asmorkalov approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

asmorkalov pushed a commit to opencv/opencv_contrib that referenced this pull request Feb 26, 2024
@stopmosk
Merge pull request #3401 from stopmosk:move-aruco-tutorial
97137ec 
Move Aruco tutorials and samples to main repo #3401

merge with opencv/opencv#23018
merge with merge with opencv/opencv_extra#1143

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov merged commit 6ca45a9 into opencv:4.x Feb 26, 2024
@asmorkalov asmorkalov self-assigned this Feb 26, 2024
@asmorkalov asmorkalov mentioned this pull request Feb 26, 2024
Merged
klatism pushed a commit to klatism/opencv that referenced this pull request May 17, 2024
@stopmosk @asmorkalov @klatism
Merge pull request opencv#23018 from stopmosk:move-aruco-tutorial
0a2702c 
Move Aruco tutorials and samples to main repo opencv#23018

merge with opencv/opencv_contrib#3401
merge with opencv/opencv_extra#1143

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake

---------
Co-authored-by: AleksandrPanov <[email protected]>
Co-authored-by: Alexander Smorkalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin left review comments

@alalek alalek alalek left review comments

@AleksandrPanov AleksandrPanov AleksandrPanov left review comments

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: documentation Documentation fix or update category: objdetect test

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@stopmosk @asmorkalov @AleksandrPanov @mshabunin @alalek