Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ported to 5.x: aspect ratio fix for fisheye camera matrix estimation #23027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ported to 5.x: aspect ratio fix for fisheye camera matrix estimation #23027

wants to merge 1 commit into from

Conversation

savuor
Copy link
Contributor

@savuor savuor commented Dec 24, 2022 •
edited
Loading

Port of #22604 to 5.x

Connected PR at extra: #1029@extra

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@savuor savuor mentioned this pull request Dec 24, 2022
Closed
@savuor
Copy link
Contributor Author

savuor commented Dec 26, 2022

The patch size check erroneously indicates that the size is >2 MB while it's less than 1 MB.
@alalek is it a problem with checker or with my PR?

@alalek
Copy link
Member

alalek commented Dec 26, 2022

PR should have 1 commit.

@savuor
aspect ratio fix
9501061 
groundtruth numbers updated

comment

write with --test_debug only

do not write to testdata

java test fixed & enabled

throw away half
@savuor savuor force-pushed the fix_fisheye_aspect_ratio_5x branch from 3b2ad69 to 9501061 Compare December 27, 2022 00:10
@alalek
Copy link
Member

alalek commented Jan 9, 2023

Merged through #23113

@savuor savuor deleted the fix_fisheye_aspect_ratio_5x branch January 18, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@savuor @alalek