Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Warning supression fix for XCode 13.1 and newer. Backport #23203 #23214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Warning supression fix for XCode 13.1 and newer. Backport #23203 #23214

merged 1 commit into from
Feb 6, 2023

Conversation

asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented Feb 2, 2023 •
edited by alalek
Loading

Backport of #23203
Backport of opencv/opencv_contrib#3434
Merge with opencv/opencv_contrib#3435

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
build_image:Custom=ubuntu-clang:18.04
buildworker:Custom=linux-1,linux-4

@asmorkalov asmorkalov mentioned this pull request Feb 2, 2023
Merged
6 tasks
@asmorkalov asmorkalov requested a review from alalek February 2, 2023 11:00
alalek
alalek approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM the proposed change 👍

But what is happened with FFmpeg on macOS-ARM64? CI is red.

BTW, OpenCV doesn't support FFmpeg 5.0+ on 3.4 branch.

@asmorkalov
Copy link
Contributor Author

It's my mistake. I installed 5.x everywhere. Will revert the change.

@asmorkalov asmorkalov force-pushed the as/xcode_warning_supression3.4 branch from 132fb28 to 9ec6058 Compare February 6, 2023 07:07
@asmorkalov asmorkalov force-pushed the as/xcode_warning_supression3.4 branch from 9ec6058 to 3d635cb Compare February 6, 2023 08:13
@alalek
Copy link
Member

alalek commented Feb 6, 2023

FFmpeg is lost completely on macOS-ARM64:

--   Video I/O:
--     DC1394:                      NO
--     FFMPEG:                      NO
--       avcodec:                   NO
--       avformat:                  NO
--       avutil:                    NO
--       swscale:                   NO
--       avresample:                NO

opencv_contrib fixes are needed too: https://github.com/opencv/opencv/actions/runs/4101618585/jobs/7073604605

@asmorkalov
Copy link
Contributor Author

I saw ffmpeg regression and contrib warnings. Working on them right now.

@asmorkalov asmorkalov mentioned this pull request Feb 6, 2023
Merged
6 tasks
@opencv-pushbot opencv-pushbot merged commit 0981814 into opencv:3.4 Feb 6, 2023
@alalek alalek mentioned this pull request Feb 11, 2023
Merged
@asmorkalov asmorkalov mentioned this pull request Apr 20, 2023
Merged
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

+1 more reviewer

@Neilblaze Neilblaze Neilblaze approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alalek alalek

Labels

category: build/install port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Milestone

3.4.20

Development

Successfully merging this pull request may close these issues.

4 participants

@asmorkalov @alalek @Neilblaze @opencv-pushbot