Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

VadimLevin
Copy link
Contributor

Named arguments handling back-port from PR #19156 to 4.x branch.
Different arguments and code generation logic is used for easier integration with PR #14590 .

Named arguments mimic normal arguments and reveal their nature only during function call inter-opt.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@VadimLevin VadimLevin force-pushed the dev/vlevin/cxx-named-arguments branch from 7aeabe2 to b07031b Compare February 6, 2023 19:16
@VadimLevin VadimLevin requested a review from vpisarev February 6, 2023 19:36
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@opencv-pushbot opencv-pushbot merged commit 44290af into opencv:4.x Feb 8, 2023
asmorkalov added a commit that referenced this pull request May 30, 2023
Re-implement named parameters bindings for Python #23705

Reverted named argument handling from #19156.
Ported new solution from #23224
The port is required to harmonize 4.x -> 5.x merges.

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: python bindings feature port/backport done Label for maintainers. Authors of PR can ignore this test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants