Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix focal length estimation from homography matrix #23247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fix focal length estimation from homography matrix #23247

merged 1 commit into from
Feb 15, 2023

Conversation

lilithgrigoryan
Copy link

@lilithgrigoryan lilithgrigoryan commented Feb 13, 2023 •
edited by alalek
Loading

Add missing denominator swap. See pictures below for before/after comparison. The function was used to create both images. Images were created by stitching two other images (I can provide source material for reproduction if needed). No other parameters were changed between two calls other than the proposed fix. Also tested on pinhole camera model.

Before fix:
photo_2023-02-13 20 28 55

After fix:
photo_2023-02-13 20 28 58

Related commit: 60e1eda

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch

@alalek
Copy link
Member

alalek commented Feb 14, 2023

Thank you for contribution!

As a "bugfix" this patch should go into 3.4 branch first.
We will merge changes from 3.4 into 4.x regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: 4.x => 3.4 (use "Edit" button near PR title)
  • rebase your commits from 4.x onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/4.x
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@lilithgrigoryan lilithgrigoryan changed the base branch from 4.x to 3.4 February 14, 2023 14:59
alalek
alalek approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for the contribution!

@opencv-pushbot opencv-pushbot merged commit 6b5be4f into opencv:3.4 Feb 15, 2023
@asmorkalov asmorkalov mentioned this pull request Apr 20, 2023
Merged
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

affected: 3.4 bug category: stitching

Projects

None yet

Milestone

3.4.20

Development

Successfully merging this pull request may close these issues.

3 participants

@lilithgrigoryan @alalek @opencv-pushbot