temporarily set "enable_precise_upscale=false" by default #23270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oradic failures in regression tests
alalek
reviewed
Feb 17, 2023
| CV_WRAP static Ptr<SIFT> create(int nfeatures = 0, int nOctaveLayers = 3, | ||
| double contrastThreshold = 0.04, double edgeThreshold = 10, | ||
| double sigma = 1.6, bool enable_precise_upscale = true); | ||
| double sigma = 1.6, bool enable_precise_upscale = false); |
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…oradic failures in regression tests (opencv#23270)
geversonsto
pushed a commit
to stodev-com-br/opencv
that referenced
this pull request
Jun 3, 2023
…oradic failures in regression tests (opencv#23270)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it looks like #23124 causes sporadic failures in regression tests. Maybe this is because warpAffine() is not bit-exact and thus this could possibly be fixed by adding another inter_linear_exact_... flavor that produces bit-exact results and that could be called from SIFT