Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Aruco/Charuco test case fixes for floating point for loops #23271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2023
Merged

Aruco/Charuco test case fixes for floating point for loops #23271

merged 2 commits into from
Mar 30, 2023

Conversation

stefan523
Copy link
Contributor

Aruco/Charuco test case for loop fixes as discussed in #23153

There are some test loops in the aruco/charuco module that do not work as intended due to floating point imprecision.

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@stefan523 stefan523 mentioned this pull request Feb 17, 2023
Merged
6 tasks
AleksandrPanov
AleksandrPanov approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@AleksandrPanov AleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support "for loop fixes", this makes the tests more understandable.
Also, I removed the image size increase so as not to increase the time of the tests. We can use "distance" param to increase aruco markers.

In current tests, there are several pixels per module. This will help track regressions, but a small change in the parameters of the tests can lead to their fall.
test

@AleksandrPanov AleksandrPanov marked this pull request as ready for review March 29, 2023 13:11
@asmorkalov asmorkalov added this to the 4.8.0 milestone Mar 30, 2023
@asmorkalov asmorkalov merged commit 3cf367c into opencv:4.x Mar 30, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AleksandrPanov AleksandrPanov AleksandrPanov approved these changes

Assignees

@AleksandrPanov AleksandrPanov

Labels

bug category: objdetect test

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@stefan523 @AleksandrPanov @asmorkalov