Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DNN Test ONNX: Fix the logic of the test case #23343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

DNN Test ONNX: Fix the logic of the test case #23343

merged 1 commit into from
Mar 13, 2023

Conversation

zihaomu
Copy link
Member

@zihaomu zihaomu commented Mar 11, 2023 •
edited
Loading

Move global_deny_list out of if condition.
global_deny_list was set to that can be parsed correctly, but cannot run on any backend.
It should have nothing to do with backend.

For example: some bad case in the global_deny_list but not in the vulkan_deny_list, the Vulkan CI will fail with these cases.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zihaomu zihaomu requested review from asmorkalov and rogday March 11, 2023 19:41
rogday
rogday approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

asmorkalov
asmorkalov reviewed Mar 13, 2023
View reviewed changes
modules/dnn/test/test_onnx_conformance.cpp
Comment on lines 1067 to 1070
if (global_deny_list.find(name) != global_deny_list.end())
{
applyTestTag(CV_TEST_TAG_DNN_SKIP_OPENCV_BACKEND, CV_TEST_TAG_DNN_SKIP_ONNX_CONFORMANCE);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no dedicated skip list for OpenCV backend after the patch. I propose to add it and let it be empty for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asmorkalov thanks for the code reviewing. To my knowledge, the cpu_deny_list is made for OpenCV backend. I'm not sure about it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@zihaomu zihaomu force-pushed the fix_test_onnx_conf branch from b306392 to ee3740a Compare March 13, 2023 14:18
@asmorkalov asmorkalov self-assigned this Mar 13, 2023
@asmorkalov asmorkalov added test category: dnn (onnx) ONNX suport issues in DNN module labels Mar 13, 2023
@asmorkalov asmorkalov added this to the 4.8.0 milestone Mar 13, 2023
@asmorkalov asmorkalov merged commit 22a5276 into opencv:4.x Mar 13, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

+1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@asmorkalov asmorkalov

Labels

category: dnn (onnx) ONNX suport issues in DNN module test

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@zihaomu @asmorkalov @rogday