added charuco board generation to gen_pattern.py #23363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
requested changes
Mar 17, 2023
asmorkalov
requested changes
Mar 22, 2023
|
OpenCV supports gziped files with |
asmorkalov
requested changes
Apr 6, 2023
doc/tutorials/calib3d/camera_calibration_pattern/camera_calibration_pattern.markdown
Outdated
Show resolved
Hide resolved
|
General remark on text: ChAruco is abbreviation. Please presume the original spelling in tutorial text and printed messages. |
asmorkalov
requested changes
Apr 10, 2023
asmorkalov
requested changes
Apr 10, 2023
asmorkalov
requested changes
Apr 10, 2023
doc/tutorials/calib3d/camera_calibration_pattern/camera_calibration_pattern.markdown
Outdated
Show resolved
Hide resolved
|
I fixed the command in the tutorial to generate board and get cropped image. |
6 tasks
asmorkalov
reviewed
Apr 12, 2023
doc/tutorials/calib3d/camera_calibration_pattern/camera_calibration_pattern.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/calib3d/camera_calibration_pattern/camera_calibration_pattern.markdown
Outdated
Show resolved
Hide resolved
|
asmorkalov
reviewed
Apr 19, 2023
4 tasks
|
|
@vovka643 I fixed predefined dictionaries search path, but the new tests still fail. The generated template (png) does not look correct. Also path to files are messed in tests. |
asmorkalov
reviewed
May 15, 2023
Comment on lines
59
to
60
| np.testing.assert_allclose(markerCorners_svg, markerCorners_cv, 0.1, 0.1) | ||
| np.testing.assert_allclose(markerIds_svg, markerIds_cv, 0.1, 0.1) |
There was a problem hiding this comment.
The files in tmp are not removed by test. It will produce a lot of garbage on CI. Please take a look on test for aruco:
. It removes temporary files every time.
6 tasks
asmorkalov
requested changes
May 17, 2023
Comment on lines
60
to
64
| finally: | ||
| if os.path.exists(filesvg): | ||
| os.remove(filesvg) | ||
| if os.path.exists(filepng): | ||
| os.remove(filepng) |
There was a problem hiding this comment.
It removes files for the last loop iteration, but not all temporary files.
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
Added charuco board generation to gen_pattern.py opencv#23363 added charuco board generation in gen_pattern.py moved aruco_dict_utils.cpp to samples from opencv_contrib (opencv/opencv_contrib#3464) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
Added charuco board generation to gen_pattern.py opencv#23363 added charuco board generation in gen_pattern.py moved aruco_dict_utils.cpp to samples from opencv_contrib (opencv/opencv_contrib#3464) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added charuco board generation in gen_pattern.py
moved aruco_dict_utils.cpp to samples from opencv_contrib (opencv/opencv_contrib#3464)
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.