Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cmake: fix V4L config verification conflict with OBSENSOR #23375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2023
Merged

cmake: fix V4L config verification conflict with OBSENSOR #23375

merged 1 commit into from
Apr 18, 2023

Conversation

mshabunin
Copy link
Contributor

@mshabunin mshabunin commented Mar 19, 2023 •
edited
Loading

resolves #23083

When building with WITH_V4L=OFF and WITH_OBSENSOR=ON config verification fails due to variable HAVE_CAMV4L being set by OBSENSOR and used for verification by V4L.

@mshabunin mshabunin mentioned this pull request Mar 19, 2023
Closed
@asmorkalov asmorkalov requested a review from fengyuentau March 20, 2023 06:42
@fengyuentau fengyuentau requested review from zihaomu and removed request for fengyuentau March 20, 2023 10:11
@asmorkalov asmorkalov added this to the 4.8.0 milestone Apr 11, 2023
@asmorkalov
Copy link
Contributor

@mshabunin Is the PR ready for review?

@asmorkalov asmorkalov marked this pull request as ready for review April 14, 2023 09:00
@mshabunin
Copy link
Contributor Author

I haven't check it myself, but it should be fine.

@zihaomu
Copy link
Member

zihaomu commented Apr 17, 2023

Hi @mshabunin, I will test it on my site.

zihaomu
zihaomu approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test with Orbbec camera, it works well.
Orbbec camera: Femto
Test platform: ARM, ubuntu 20.04.
Compiler config:

-D WITH_V4L=OFF \
-D WITH_OBSENSOR=ON \

@asmorkalov asmorkalov merged commit b68aa12 into opencv:4.x Apr 18, 2023
@mshabunin mshabunin deleted the fix-v4l-verify branch April 18, 2023 11:44
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zihaomu zihaomu zihaomu approved these changes

Assignees

@zihaomu zihaomu

Labels

category: build/install category: videoio(camera)

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

Verifying the config fails if option is disabled but prerequisites exist, that seems flawed?

3 participants

@mshabunin @asmorkalov @zihaomu